Open
Conversation
MatiasArriola
force-pushed
the
workaround/sms-disable-encoding-for-json-body
branch
from
51632e2 to
ea4d9e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required by https://app.clickup.com/t/8696nmumu
Motivation: When a SMS message body is "word1 word", the final request is "word1+word". This URL encoding makes sense when the body is part of a query string, but that's not our use case (nor the typical use case), when we POST the body as JSON, so no encoding is required. We add a conditional so we do not break URL mode.