feat: add CloudFront component #84
Open
+679
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
droguljic
force-pushed
the
feat/cloudfront
branch
2 times, most recently
from
ed85a45 to
bd7c17c
Compare
droguljic
force-pushed
the
feat/cloudfront
branch
from
bd7c17c to
5ec97e1
Compare
droguljic
force-pushed
the
feat/cloudfront
branch
from
5ec97e1 to
af2a951
Compare
Exposing CloudFront as a independent component adds flexibility and supports use cases such as multiple origins per distribution. Three types of behaviors are supported: - S3, tailored for S3 origins with auto-configuration including cache policy oriented towards static assets and response headers policy with security headers. - LB, tailored for ALB origins with auto-configuration including cache policy for dynamic content and response headers policy with security headers. - Custom, configurable option with by default disabled caching.
droguljic
force-pushed
the
feat/cloudfront
branch
from
af2a951 to
462b9e8
Compare
bornast
requested changes
Jan 13, 2026
| export class CloudFront extends pulumi.ComponentResource { | ||
| name: string; | ||
| distribution: aws.cloudfront.Distribution; | ||
| acmCertificate?: AcmCertificate; |
Member
There was a problem hiding this comment.
Here we are exposing the acmCertificate prop but in a case where we send a certificate, this prop will be undefined. Would it be better to unify them both under one prop?
Comment on lines
+8
to
+12
| export enum BehaviorType { | ||
| S3 = 's3', | ||
| LB = 'lb', | ||
| CUSTOM = 'custom', | ||
| } |
Member
There was a problem hiding this comment.
Would it make sense to move this to types.ts?
| cachePolicy: aws.cloudfront.CachePolicy; | ||
| originRequestPolicy?: aws.cloudfront.OriginRequestPolicy; | ||
| responseHeadersPolicy?: aws.cloudfront.ResponseHeadersPolicy; | ||
| getPathConfig: () => aws.types.input.cloudfront.DistributionOrderedCacheBehavior; |
Member
There was a problem hiding this comment.
do we need this method, i don't see it being used anywhere?
| pathPattern: string; | ||
| config: aws.types.input.cloudfront.DistributionDefaultCacheBehavior; | ||
| cachePolicy: aws.cloudfront.CachePolicy; | ||
| originRequestPolicy?: aws.cloudfront.OriginRequestPolicy; |
Member
There was a problem hiding this comment.
Do we need this since it’s not being set anywhere?
I see we already have an originRequestPolicyId though.
bornast
requested changes
Jan 13, 2026
| orderedCaches, | ||
| domain, | ||
| certificate, | ||
| defaultRoot, |
Member
There was a problem hiding this comment.
can we name this defaultRootObject as the prop name?
| private createDistributionOrigins( | ||
| behaviors: CloudFront.Args['behaviors'], | ||
| ): pulumi.Output<aws.types.input.cloudfront.DistributionOrigin[]> { | ||
| return pulumi.all(behaviors.map(b => pulumi.output(b))).apply(entries => { |
Member
There was a problem hiding this comment.
Suggested change
| return pulumi.all(behaviors.map(b => pulumi.output(b))).apply(entries => { | |
| return pulumi.output(behaviors).apply(entries => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposing CloudFront as a independent component adds flexibility and supports use cases such as multiple origins per distribution. Three types of behaviors are supported: