Skip to content

[OnyxAudit] Remove RAM-only check from OnyxUtils remove function #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
JKobrynski wants to merge 2 commits into
base: main
Choose a base branch
from
+16 −4
Draft

[OnyxAudit] Remove RAM-only check from OnyxUtils remove function #736

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0702cd9
remove RAM-only check from OnyxUtils remove function
JKobrynski Feb 16, 2026
b778c4f
add a unit test for the edited use case
JKobrynski Feb 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions lib/OnyxUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -899,10 +899,6 @@ function remove<TKey extends OnyxKey>(key: TKey, isProcessingCollectionUpdate?:
cache.drop(key);
scheduleSubscriberUpdate(key, undefined as OnyxValue<TKey>, undefined, isProcessingCollectionUpdate);

if (isRamOnlyKey(key)) {
return Promise.resolve();
}

return Storage.removeItem(key).then(() => undefined);
}

Expand Down
16 changes: 16 additions & 0 deletions tests/unit/onyxUtilsTest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,6 +491,22 @@ describe('OnyxUtils', () => {
});
});

describe('remove', () => {
it('should remove RAM-only key from storage when set to null', async () => {
const removeItemSpy = jest.spyOn(StorageMock, 'removeItem');

// First set the RAM-only key to a value
await Onyx.set(ONYXKEYS.RAM_ONLY_KEY, 'testValue');

removeItemSpy.mockClear();

// Setting null should trigger OnyxUtils.remove, which should also remove from storage
await Onyx.set(ONYXKEYS.RAM_ONLY_KEY, null);

expect(removeItemSpy).toHaveBeenCalledWith(ONYXKEYS.RAM_ONLY_KEY);
});
});

describe('isRamOnlyKey', () => {
it('should return true for RAM-only key', () => {
expect(OnyxUtils.isRamOnlyKey(ONYXKEYS.RAM_ONLY_KEY)).toBeTruthy();
Expand Down