Skip to content

[WIP] Improve multiGet, multiSet and multiMerge SQL operations #732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
fabioh8010 wants to merge 7 commits into
base: main
Choose a base branch
from
+4 −4
Draft

[WIP] Improve multiGet, multiSet and multiMerge SQL operations #732

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c51e083
Improvements in SQLiteProvider
fabioh8010 Jan 29, 2026
c81b469
Merge branch 'main' into feature/sqliteprovider-improvements
fabioh8010 Feb 5, 2026
85bf84d
Minor fix in table name string
fabioh8010 Feb 6, 2026
7744966
Add comments
fabioh8010 Feb 6, 2026
6929683
Always drop the temporary table
fabioh8010 Feb 6, 2026
0e80d49
Merge branch 'main' into feature/sqliteprovider-improvements
fabioh8010 Feb 17, 2026
0f17bdb
Revert multiGet changes
fabioh8010 Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/storage/providers/SQLiteProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ const provider: StorageProvider<NitroSQLiteConnection | undefined> = {
throw new Error('Store is not initialized!');
}

const query = 'REPLACE INTO keyvaluepairs (record_key, valueJSON) VALUES (?, json(?));';
const query = 'REPLACE INTO keyvaluepairs (record_key, valueJSON) VALUES (?, ?);';
const params = pairs.map((pair) => [pair[0], JSON.stringify(pair[1] === undefined ? null : pair[1])]);
if (utils.isEmptyObject(params)) {
return Promise.resolve();
Expand All @@ -143,15 +143,15 @@ const provider: StorageProvider<NitroSQLiteConnection | undefined> = {

// Query to merge the change into the DB value.
const patchQuery = `INSERT INTO keyvaluepairs (record_key, valueJSON)
VALUES (:key, JSON(:value))
VALUES (:key, :value)
ON CONFLICT DO UPDATE
SET valueJSON = JSON_PATCH(valueJSON, JSON(:value));
SET valueJSON = JSON_PATCH(valueJSON, :value);
`;
const patchQueryArguments: string[][] = [];

// Query to fully replace the nested objects of the DB value.
const replaceQuery = `UPDATE keyvaluepairs
SET valueJSON = JSON_REPLACE(valueJSON, ?, JSON(?))
SET valueJSON = JSON_REPLACE(valueJSON, ?, ?)
WHERE record_key = ?;
`;
const replaceQueryArguments: string[][] = [];
Expand Down
Loading