Skip to content

fix: status is infinity loading for the none-exist key #709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arosiclair merged 4 commits into from
Dec 17, 2025
Merged

fix: status is infinity loading for the none-exist key #709

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
181fb70
fix: status is infinity loading for the none-exist key
nkdengineer Dec 6, 2025
512a341
update the correct approach
nkdengineer Dec 6, 2025
25b377b
Merge branch 'main' into fix/75794
nkdengineer Dec 15, 2025
5f55dc3
update condition and comment
nkdengineer Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/useOnyx.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,8 +313,9 @@ function useOnyx<TKey extends OnyxKey, TReturnValue = OnyxValue<TKey>>(
// - The previously cached value is different from the new value.
// - The previously cached value is `null` (not set from cache yet) and we have cache for this key
// OR we have a pending `Onyx.clear()` task (if `Onyx.clear()` is running cache might not be available anymore
// OR the subscriber is triggered (the value is gotten from the storage)
// so we update the cached value/result right away in order to prevent infinite loading state issues).
const shouldUpdateResult = !areValuesEqual || (previousValueRef.current === null && (hasCacheForKey || OnyxCache.hasPendingTask(TASK.CLEAR)));
const shouldUpdateResult = !areValuesEqual || (previousValueRef.current === null && (hasCacheForKey || OnyxCache.hasPendingTask(TASK.CLEAR) || !isFirstConnectionRef.current));
if (shouldUpdateResult) {
previousValueRef.current = newValueRef.current;

Expand Down