perf: preserve references of unchanged collection items v2 #707

TMisiukiewicz · 2025-12-02T13:48:50Z

Details

Another attempt after reverting #693.

When setCollection/mergeCollection/partialSetCollection are called from OpenApp and ReconnectApp, it should preserve references for all the items that are unchanged to reduce the amount of the re-renders of the components connected to collection items that did not change.

$ Expensify/App#72679

=== 📁 Trace File Analysis ===

📄 File: profiling-data.02.12.2025.14-57-32.json
  • Commit count: 17
  • Total render duration: 609.893 ms
  • p50 / p95 / p99 (ms):
    • p50: 1.352 ms
    • p95: 321.086 ms
    • p99: 321.086 ms

📄 File: profiling-data.02.12.2025.14-58-32.json
  • Commit count: 9
  • Total render duration: 132.325 ms
  • p50 / p95 / p99 (ms):
    • p50: 1.263 ms
    • p95: 119.362 ms
    • p99: 119.362 ms

=== 📊 Trace Comparison ===

🔁 Comparing Baseline ↔️ profiling-data.02.12.2025.14-58-32.json
  🟢 Duration Diff: -477.568 ms (-78.3%)
  🟢 Commit Count Diff: -8

Related Issues

Expensify/App#74385
Expensify/App#74405
Expensify/App#74406

Automated Tests

Added required unit tests

Manual Tests

Test 1

Open app
Go to Settings -> Troubleshoot
Clear cache and restart
Go back to LHN
Verify the LHN is displayed correctly

Test 2 - Expensify/App#74385

Go to workspace chat.
Create an expense.
Open the report.
Click More > Split
Click Save.
Open any split.
Click More > Edit splits.
Click on the other split (not highlighted).
Click Remove split.
Click Save.
Click More.
Verify split, hold and merge options are visible

Test 3 - Expensify/App#74406

Open the Expensify app
Open any workspace chat
Create three manual expenses
Navigate to "Reports" > "Reports"
Expand the preview of the just created report
Long tap and select two of the three expenses
Tap on the dropdown menu and delete both expenses
Navigate to workspace chat again
Verify the report preview displays "1 expense" and the two deleted expenses are not displayed

Test 4 - Expensify/App#74405

Go to workspace chat
Create an expense
Open the report
Click More > Split
Click Save
Open any split
Delete the split
8.Create another expense in the same report
Go offline
Remove the split
Verify the removed split does not reappear

Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

iOS: Native

ios.mov

iOS: mWeb Safari

ios-web.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

TMisiukiewicz · 2025-12-02T14:08:24Z

failing perf tests are expected

dukenv0307 · 2025-12-02T15:49:12Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-12-02.at.23.56.59.mov

Android: mWeb Chrome

Screen.Recording.2025-12-02.at.23.51.49.mov

iOS: HybridApp

Screen.Recording.2025-12-02.at.23.55.18.mov

iOS: mWeb Safari

Screen.Recording.2025-12-02.at.23.47.55.mov

MacOS: Chrome / Safari

Screen.Recording.2025-12-02.at.22.37.30.mov

Screen.Recording.2025-12-02.at.22.39.42.mov

Screen.Recording.2025-12-02.at.22.43.33.mov

Screen.Recording.2025-12-02.at.22.46.05.mov

dukenv0307 · 2025-12-02T17:02:55Z

I found 2 issues, but they're not related to this PR, I still can reproduce on main

Test 1: Empty space after clear cache and reset

Test 3: The report displays incorrectly after removing 2 expenses

JS00001 · 2025-12-02T17:57:19Z

@dukenv0307 could you please post those bugs in #expensify-bugs?

JS00001 · 2025-12-02T18:01:30Z

@TMisiukiewicz

Merging is blocked
Commits must have verified signatures.

TMisiukiewicz · 2025-12-03T05:12:17Z

@JS00001 oh damn, I switched to new Macbook last week and forgot 🤦 Let me fix this

TMisiukiewicz · 2025-12-03T06:20:59Z

Huh, modifying git history is insane, but I think it should be good now 😅

dukenv0307 · 2025-12-03T09:23:45Z

@dukenv0307 could you please post those bugs in #expensify-bugs?

I reported the first bug here, but for the second one I can't reproduce.

os-botify · 2025-12-03T11:58:22Z

🚀 Published to npm in 3.0.19 🎉

…/preserve-references-of-unchanged-collection-items" This reverts commit 3877aae, reversing changes made to ae1ec3f.

Revert Merge pull request #707

…e-references-of-unchanged-collection-items perf: preserve references of unchanged collection items v2

TMisiukiewicz requested a review from a team as a code owner December 2, 2025 13:48

melvin-bot bot assigned TMisiukiewicz Dec 2, 2025

melvin-bot bot requested review from amyevans and removed request for a team December 2, 2025 13:49

JS00001 self-requested a review December 2, 2025 14:09

amyevans removed their request for review December 2, 2025 15:51

dukenv0307 approved these changes Dec 2, 2025

View reviewed changes

JS00001 approved these changes Dec 2, 2025

View reviewed changes

TMisiukiewicz force-pushed the feat/preserve-references-of-unchanged-collection-items branch from 4c8a2b5 to 15fab94 Compare December 3, 2025 05:55

TMisiukiewicz added 2 commits December 3, 2025 07:16

Fix collection subscribers not notified about removed items

ec5af2e

return with nulls

a493500

TMisiukiewicz force-pushed the feat/preserve-references-of-unchanged-collection-items branch from fa3b8b4 to a493500 Compare December 3, 2025 06:18

JS00001 approved these changes Dec 3, 2025

View reviewed changes

JS00001 merged commit 3877aae into Expensify:main Dec 3, 2025
7 of 8 checks passed

TMisiukiewicz mentioned this pull request Dec 3, 2025

Bump Onyx to 3.0.19 Expensify/App#76637

Merged

53 tasks

mountiny added a commit that referenced this pull request Dec 9, 2025

Merge pull request #712 from callstack-internal/revert-707

daff9f3

Revert Merge pull request #707

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

perf: preserve references of unchanged collection items v2 #707

perf: preserve references of unchanged collection items v2 #707

Uh oh!

TMisiukiewicz commented Dec 2, 2025 •

edited by JS00001

Loading

Uh oh!

TMisiukiewicz commented Dec 2, 2025

Uh oh!

dukenv0307 commented Dec 2, 2025 •

edited

Loading

Uh oh!

dukenv0307 commented Dec 2, 2025 •

edited

Loading

Uh oh!

JS00001 commented Dec 2, 2025

Uh oh!

JS00001 commented Dec 2, 2025

Uh oh!

TMisiukiewicz commented Dec 3, 2025

Uh oh!

TMisiukiewicz commented Dec 3, 2025

Uh oh!

dukenv0307 commented Dec 3, 2025 •

edited

Loading

Uh oh!

Uh oh!

os-botify bot commented Dec 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

perf: preserve references of unchanged collection items v2 #707

perf: preserve references of unchanged collection items v2 #707

Uh oh!

Conversation

TMisiukiewicz commented Dec 2, 2025 • edited by JS00001 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Related Issues

Automated Tests

Manual Tests

Author Checklist

Screenshots/Videos

Uh oh!

TMisiukiewicz commented Dec 2, 2025

Uh oh!

dukenv0307 commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

dukenv0307 commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JS00001 commented Dec 2, 2025

Uh oh!

JS00001 commented Dec 2, 2025

Uh oh!

TMisiukiewicz commented Dec 3, 2025

Uh oh!

TMisiukiewicz commented Dec 3, 2025

Uh oh!

dukenv0307 commented Dec 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

os-botify bot commented Dec 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

TMisiukiewicz commented Dec 2, 2025 •

edited by JS00001

Loading

dukenv0307 commented Dec 2, 2025 •

edited

Loading

dukenv0307 commented Dec 2, 2025 •

edited

Loading

dukenv0307 commented Dec 3, 2025 •

edited

Loading