Skip to content

Add cover submitBehavior prop #745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roryabraham merged 1 commit into from
Dec 29, 2025
Merged

Add cover submitBehavior prop #745

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 19 additions & 7 deletions src/MarkdownTextInput.web.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ const MarkdownTextInput = React.forwardRef<MarkdownTextInput, MarkdownTextInputP
autoCapitalize = 'sentences',
autoCorrect = true,
blurOnSubmit = false,
submitBehavior,
caretHidden,
clearTextOnFocus,
dir = 'auto',
Expand Down Expand Up @@ -518,9 +519,19 @@ const MarkdownTextInput = React.forwardRef<MarkdownTextInput, MarkdownTextInputP
return;
}

const blurOnSubmitDefault = !multiline;
const shouldBlurOnSubmit = blurOnSubmit === null ? blurOnSubmitDefault : blurOnSubmit;

// Support submitBehavior prop (React Native 0.73+), fallback to blurOnSubmit for backwards compatibility
let shouldBlurOnSubmit;
let shouldSubmit;
if (submitBehavior != null) {
// submitBehavior takes precedence over blurOnSubmit
shouldSubmit = submitBehavior === 'submit' || submitBehavior === 'blurAndSubmit';
shouldBlurOnSubmit = submitBehavior === 'blurAndSubmit';
} else {
// Fallback to blurOnSubmit logic for backwards compatibility
const blurOnSubmitDefault = !multiline;
shouldBlurOnSubmit = blurOnSubmit === null ? blurOnSubmitDefault : blurOnSubmit;
shouldSubmit = blurOnSubmit || !multiline;
}
const nativeEvent = e.nativeEvent;
const isComposing = isEventComposing(nativeEvent);

Expand All @@ -538,19 +549,20 @@ const MarkdownTextInput = React.forwardRef<MarkdownTextInput, MarkdownTextInputP
) {
// prevent "Enter" from inserting a newline or submitting a form
e.preventDefault();
if (!e.shiftKey && (blurOnSubmit || !multiline) && onSubmitEditing) {
// submitBehavior === 'newline' means don't submit, just insert newline (default behavior)
if (!e.shiftKey && shouldSubmit && onSubmitEditing) {
onSubmitEditing(event as unknown as NativeSyntheticEvent<TextInputSubmitEditingEventData>);
} else if (multiline) {
} else if (multiline && (!shouldSubmit || e.shiftKey)) {
// We need to change normal behavior of "Enter" key to insert a line breaks, to prevent wrapping contentEditable text in <div> tags.
// Thanks to that in every situation we have proper amount of new lines in our parsed text. Without it pressing enter in empty lines will add 2 more new lines.
insertText(e, '\n');
}
if (!e.shiftKey && ((shouldBlurOnSubmit && hostNode !== null) || !multiline)) {
if (!e.shiftKey && shouldBlurOnSubmit && hostNode !== null) {
setTimeout(() => divRef.current && divRef.current.blur(), 0);
}
}
},
[multiline, blurOnSubmit, setEventProps, onKeyPress, handleOnChangeText, onSubmitEditing, insertText],
[multiline, blurOnSubmit, submitBehavior, setEventProps, onKeyPress, handleOnChangeText, onSubmitEditing, insertText],
);

const handleFocus: FocusEventHandler<HTMLDivElement> = useCallback(
Expand Down