fix: update currentlyFocusedNode on focus #680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
Skalakid
suggested changes
May 20, 2025
Contributor
Skalakid
left a comment
Skalakid
left a comment
There was a problem hiding this comment.
Some checks fail, please fix lint errors
tomekzaw
reviewed
May 20, 2025
Member
|
@Skalakid Let's get this merged. Thanks. |
Skalakid
approved these changes
May 26, 2025
Contributor
16 tasks
| const handleBlur: FocusEventHandler<HTMLDivElement> = useCallback( | ||
| (event) => { | ||
| const e = event as unknown as NativeSyntheticEvent<TextInputFocusEventData>; | ||
| RNTextInput.State.blurTextInput?.(e.target); |
There was a problem hiding this comment.
Hi, coming from Expensify/App#72458, the input lose focused when switching between tabs, and we have fixed it here #736.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
_currentlyFocusedNodewhen the markdown text input receives focus.Related Issues
Expensify/App#61521
Manual Tests
Linked PRs
Result:
Screen.Recording.2025-05-20.at.17.58.29.mov