Add a toggle to add timestamps to relative dates #292
Conversation
src/js/lib/pages/github/all.js
Outdated
| // Set up timestamp format conversion | ||
| const applyTimestampFormatPeriodic = AllPages.applyTimestampFormat(); | ||
| setTimeout(() => applyTimestampFormatPeriodic(), 500); | ||
| setInterval(() => applyTimestampFormatPeriodic(), 2000); |
There was a problem hiding this comment.
I'm not too sure how this works, but a constant loop to do this seems a bit excessive. Could we just apply timestamp on page load rather than every 2 seconds?
There was a problem hiding this comment.
so I think this is to allow for things like "load more" button presses, so we probably want it at least somewhat periodically? Can definitely slow it down, though - let me know what you think!
There was a problem hiding this comment.
Most of the changes that k2 makes on typical pages are done repeatedly, but I don't know how frequent it needs to be. I bet we could consolidate them all down to like every 5 sec and no one would notice a difference
|
okay i simplified the timestamp stuff to only one interval, and set it to 5 seconds |
| } | ||
|
|
||
| ghToken = preferences.ghToken; | ||
| useAbsoluteTimestamps = preferences.useAbsoluteTimestamps || false; |
| } | ||
|
|
||
| function getUseAbsoluteTimestamps() { | ||
| return useAbsoluteTimestamps || false; |
| } | ||
|
|
||
| // Set up timestamp format conversion | ||
| const applyTimestampFormatPeriodic = AllPages.applyTimestampFormat(); |
There was a problem hiding this comment.
Why do we return a function here? Why not use AllPages.applyTimestampFormat as the function for the settimeout/setinterval? Is it so that we only call it once?
| const absoluteTime = formatTimestamp(datetime); | ||
| absoluteSpan.textContent = ` (${absoluteTime})`; | ||
| absoluteSpan.dataset.k2AbsolutePart = 'true'; | ||
|
|
There was a problem hiding this comment.
Why do we use strings for bools here? Is this common elsewhere?
As the title says.
This was 99% Cursor, not me, so feel free to rip it apart. Seems to work okay though.
Look at the bottom of your sidebar (example, on this PR!) and try toggling timestamps on and off! That's all this does, but it seems helpful - https://expensify.slack.com/archives/CDXCTAJQP/p1766012917820919