[iOS] Fix crash after inviting a user to a group chat#87169
Open
marufsharifi wants to merge 1 commit intoExpensify:mainfrom
Open
[iOS] Fix crash after inviting a user to a group chat#87169marufsharifi wants to merge 1 commit intoExpensify:mainfrom
marufsharifi wants to merge 1 commit intoExpensify:mainfrom
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
joekaufmanexpensify
approved these changes
Apr 8, 2026
Contributor
joekaufmanexpensify
left a comment
There was a problem hiding this comment.
Good for product
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
This change makes the group members' screens more stable right after inviting someone new. Instead of piecing together member states from several sources that can briefly disagree, it now relies on a single, pre-derived participant model. That removes the timing gap that could cause the iOS crash after inviting a new user to a group chat.
It also makes the member list behave more predictably during invite and removal transitions. Pending deletions, optimistic users, roles, and disabled states are now determined once before rendering, so the screen shows a cleaner, more reliable view of who is actually in the chat at that moment.
Fixed Issues
$ #78097
PROPOSAL: #78097 (comment)
Tests
Offline tests
Same as Tests.
QA Steps
Same as Tests.
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
REC-20260406100511.PM.mp4
Android: mWeb Chrome
REC-2026040695040.PM.mp4
iOS: Native
REC-2026040692851.PM.mp4
iOS: mWeb Safari
REC-2026040693654.PM.mp4
MacOS: Chrome / Safari
REC-2026040691821.PM.mp4