feat: Update option missing for Personal Bank Accounts in ND compared to Classic

[TaduJR]

Explanation of Change

This PR adds an "Action required" badge and update flow for US personal bank accounts missing owner information (name, address, phone number), which is needed for global reimbursement payments to succeed.

What it does:

• Detects US personal bank accounts in OPEN state missing required additionalData fields (firstName, lastName, addressStreet, addressCity, addressState, addressZipCode, companyPhone)
• Shows a green "Action required" badge with brick road indicator on affected bank account rows in the Wallet
• Tapping the row navigates to a multi-step update flow that only prompts for missing fields (reuses LegalNameStep, AddressStep, PhoneNumberStep from the international deposit account flow)
• On confirmation, calls UpdatePersonalBankAccountInfo API to save the data
• Optimistically updates all affected bank accounts' additionalData with rollback on failure
• Shows a success screen with fireworks animation on completion
• Three-dots menu remains accessible for delete/default/share actions

Fixed Issues

$ #76053
PROPOSAL: #76053 (comment)

Tests

Prerequisite: User with a US personal bank account that has missing personal info (name, address, or phone) connected to the wallet

1. Navigate to Settings > Wallet
2. Verify the affected bank account row shows a green "Action required" badge
3. Tap the bank account row — verify it opens the "Update bank account" flow
4. Tap the three-dots menu (⋯) on the same row — verify the popover with Delete/Make default still opens separately
5. Complete the update flow:
   • If name is missing: verify the "What's your legal name?" step appears
   • If address is missing: verify the "What is your address?" step appears
   • If phone is missing: verify the "What's your phone number?" step appears
   • Steps for info the account already has should be skipped automatically
6. On the last step, tap the button — verify the form submits directly (there is no confirmation/review screen)
7. On success: verify the "Bank account updated!" screen appears with fireworks animation and a "Continue" button
8. Tap Continue — verify it navigates back to Wallet
9. Verify the "Action required" badge is gone from that bank account row
10. If the user has multiple personal bank accounts missing info, verify the badge is only removed from the account that was just updated — other accounts still show their badge

Regression Tests

Regression 1 - #86803: "Action required shown when legal name is already filled"

1. Add a new US personal bank account via Settings > Wallet > Add bank account > Get reimbursed > United States
2. Complete the full Plaid flow including legal name, address, and phone number
3. Tap Confirm and then Continue
4. Navigate to Settings > Wallet
5. Verify the newly added personal bank account does not show an "Action required" badge
6. Navigate to Settings > Profile > Private details — verify the legal name is filled in

Regression 2 - #86832: "Default label not displayed when account has Action required badge"

1. Have a US personal bank account with missing info (shows "Action required" badge)
2. Tap the three-dots menu (⋯) on that bank account
3. Select Make default payment method
4. Verify the "Default" label is displayed on the bank account row alongside the "Action required" badgee from all of them

• Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS-Native.mp4

iOS: mWeb Safari

MacOS: Chrome / Safari

Mac-Chrome.mp4

[melvin-bot]

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

1. Look at the code and make sure there are no malicious changes.
2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

[melvin-bot]

@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[codecov]

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/CONST/index.ts	93.65% <ø> (ø)
src/SCREENS.ts	100.00% <ø> (ø)
src/components/AddressForm.tsx	98.07% <100.00%> (+0.07%)	⬆️
src/hooks/useAccountIndicatorChecks.ts	100.00% <100.00%> (ø)
src/libs/API/types.ts	100.00% <ø> (ø)
src/libs/BankAccountUtils.ts	87.75% <100.00%> (+44.89%)	⬆️
...igation/linkingConfig/RELATIONS/SETTINGS_TO_RHP.ts	100.00% <ø> (ø)
src/libs/Navigation/linkingConfig/config.ts	76.92% <ø> (ø)
...sitAccount/PersonalInfo/substeps/LegalNameStep.tsx	0.00% <ø> (ø)
src/pages/settings/Wallet/PaymentMethodList.tsx	0.00% <ø> (ø)
... and 10 more
... and 28 files with indirect coverage changes

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 372631afba

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[dukenv0307]

@TaduJR Can you explain the RCAs and solutions to fix the regressions briefly? Thanks

[TaduJR]

@codex review

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 381dd27811

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[TaduJR]

@codex review

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e3a6f4de6c

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[TaduJR]

@codex review

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b67e3a4cc2

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[TaduJR]

@TaduJR Can you explain the RCAs and solutions to fix the regressions briefly? Thanks

@dukenv0307

Regression #86803 - "Action required shown when legal name is already filled"

RCA: isPersonalBankAccountMissingInfo() only checked the bank account's additionalData for name/address/phone. However, the backend does not write firstName/lastName to additionalData when adding a personal bank account - it only stores them in privatePersonalDetails (user profile). So freshly-added accounts always appeared as "missing info" even when the user provided their name during the Plaid flow.

Fix: Added privatePersonalDetails as a fallback parameter to isPersonalBankAccountMissingInfo() and getCompletedStepsForBankAccount(). Both now check additionalData first, then fall back to the user's profile (legalFirstName/legalLastName, getCurrentAddress(), phoneNumber). Also handles dual Address field names (street/addressLine1, zip/zipPostCode).

Regression #86832 — "Default label not displayed when account has Action required badge"

RCA: The badge if/else if chain in PaymentMethodListItem made "Action required" and "Default" mutually exclusive - an account that was both default and needing action only showed "Action required".

Fix: Added a combined branch: when both isNeedingAction and shouldShowDefaultBadge are true, the badge shows "Default · Action required". This is a single-badge workaround since MenuItem only supports one badgeText.