Multi file upload support (v2)#84423
Conversation
|
|
|
@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: eb4eba1573
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
Kicked off a build and this action too https://github.com/Expensify/App/actions/runs/22778476616 |
This comment has been minimized.
This comment has been minimized.
joekaufmanexpensify
left a comment
There was a problem hiding this comment.
Good for product
…necessary patch changes
|
On Android, when I select multiple attachments, the app only show preview for 2. 07.03.2026_18.53.07_REC.mp4 |
|
A comment here #84423 (comment) @chrispader |
@parasharrajat working on it. Somehow |
|
🚧 @grgia has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
After investigating this further, i think we are pretty much limited by the iOS I'm trying to get some more heads on this within Margelo, but i fear we might be limited by the Since this is also the case on |
|
That's why I already approved. I am good with this case as I think copying and pasting files is not a common pattern for native apps. |
|
Sounds good @chrispader, do we need a new issue? |
|
@grgia looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
🚧 @grgia has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/grgia in version: 9.3.50-0 🚀
Bundle Size Analysis (Sentry): |
|
I have failed to help you. I let you down and for that I am sorry. Please try again later. This may be due to a Claude outage (check here). Failure details: https://github.com/Expensify/Expensify/actions/runs/23647046284 |
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.3.50-8 🚀
|
@parasharrajat @mountiny
Explanation of Change
This PR is a follow-up after #68551 has been reverted in #83956
Updates the native
react-nativepatch which impementsonPastecallback onTextInput, to allow pasting multiple files into the input.Updates the composer implementation to handle multiple files that were drag'n'dropped. This allows the user to drop multiple files into the composer at once, which will then be displayed in an attachment gallery preview.
Even though there is a limitation on iOS where multiple files in the clipboard are not passed to the input
onPasteFilecallback, i still adapted the implementation to allow for potentially more clipboard items.react-native-live-markdownPR: Expensify/react-native-live-markdown#753react-native-live-markdownversion bump PR: #83041Fixed Issues
$ #53493
$ #59443
PROPOSAL:
Tests
Drag'n'Drop
Paste from clipboard
Offline tests
None needed.
QA Steps
Same as in Tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
XRecorder_20260218_02.mp4
iOS: Native
Simulator.Screen.Recording.-.iPhone.17.Pro.-.2026-02-18.at.20.27.14.mov
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-02-18.at.13.26.19.mov
Screen.Recording.2026-02-18.at.13.25.47.mov
MacOS: Desktop