[No QA] Merging main on help article PR#84316
[No QA] Merging main on help article PR#84316joekaufmanexpensify wants to merge 10000 commits intoVictoriaExpensify-patch-5from
Conversation
…ection [No QA] Help site updates for change accounting section into multiple sections
…mportMemberFields Co-authored-by: truph01 <truph01@users.noreply.github.com>
[NoQA] Implement the freeze and unfreeze options for admins
…-page-filter-inconsistencies-and-clean-up # Conflicts: # src/components/Search/SearchPageHeader/SearchFiltersBar.tsx # tests/unit/Search/SearchUIUtilsTest.ts
…-empty-states # Conflicts: # src/components/EmptyStateComponent/index.tsx # src/components/EmptyStateComponent/types.ts # src/pages/Search/EmptySearchView.tsx # src/pages/TransactionMerge/MergeTransactionsListContent.tsx # src/pages/workspace/companyCards/WorkspaceCompanyCardsFeedAddedEmptyPage.tsx # src/pages/workspace/companyCards/WorkspaceCompanyCardsFeedPendingPage.tsx # src/pages/workspace/expensifyCard/EmptyCardView.tsx
…-page-filter-inconsistencies-and-clean-up
…-fork into Guccio163/onyx-connect/policy_tags/duplicateExpenseTransaction
…-message-frontend Send bespoke welcome message optimistically from frontend
[No QA] fix: PR Reviewer Checklist fails if more than 1 comment contains # Reviewer Checklist text
…sed-disable-directives Revert "[No QA] Remove unused eslint-disable directives"
…onnect/policy_tags/duplicateExpenseTransaction Remove Onyx.connect() for the key: ONYXKEYS.COLLECTION.POLICY_TAGS from duplicateExpenseTransaction function
fix:78356: Back button on Validate your bank account page does nothing
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…e-time-typeguard-safety Fix (telemetry): guard __moduleInitTimes access to prevent ReferenceError
Optimize getSections performance in SearchUIUtils
…ngCsvImportMemberFields
fix: Expensify card - The Choose a limit type page re-appears briefly
…ders [No QA] Integrations Error Revamp: Create folders for integration troubleshooting docs
…angesConfirmation`"
fix: send custom unit ids for distance rate and per-diem custom units
…nt-exact-match [CP both] Fix subscription payment history not showing bills after merchant exact match change
Revert "Migrate `useBeforeRemove` to `usePreventRemove` in `DiscardChangesConfirmation`"
fix: remove feature name from PublicDomainErrorPage
Optimize SearchTypeMenu
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
github-actions
bot
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9d50c7ad70
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| core.warning(`PR #${prNumber} diff is too large for the GitHub API. Skipping incremental change detection.`); | ||
| core.setOutput('CHANGED_FILES', JSON.stringify([])); | ||
| core.setOutput('HAS_CHANGES', false); | ||
| return; |
There was a problem hiding this comment.
When getPullRequestDiff() returns too_large, this branch sets HAS_CHANGES to false and exits, even though localChangedFiles already proved files changed in the pushed range. In generateTranslations.yml, all translation steps are gated on steps.check-en-changes.outputs.HAS_CHANGES == 'true', so large PRs that modify src/languages/en.ts will incorrectly skip translation generation entirely. Instead of reporting no changes, this path should use the local diff as a fallback (or fail loudly) so real updates are not dropped.
Useful? React with 👍 / 👎.
| // eslint-disable-next-line @typescript-eslint/naming-convention | ||
| workflow_id: workflowID, | ||
| // eslint-disable-next-line @typescript-eslint/naming-convention | ||
| per_page: queueLimit, |
There was a problem hiding this comment.
This check only requests the most recent queueLimit runs and then filters by id < currentRunID; if more than queueLimit newer runs exist, older active runs fall off the first page and the action can incorrectly proceed while earlier runs are still in progress. In high-traffic periods this breaks the FIFO guarantee advertised by the action and allows out-of-order execution of testBuildOnPush runs.
Useful? React with 👍 / 👎.
20 participants
Explanation of Change
Merging Main on help article PR per this
Fixed Issues
$ https://expensify.slack.com/archives/C02QSAC6BJ8/p1772739499004489?thread_ts=1772561578.595719&cid=C02QSAC6BJ8
QA Steps
N/A
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.