Skip to content

fix: Unable to Scroll in Right-Hand Panel (RHP) for Certain Expenses.#83944

Open
Krishna2323 wants to merge 7 commits intoExpensify:mainfrom
Krishna2323:krishna2323/issue/81195
Open

fix: Unable to Scroll in Right-Hand Panel (RHP) for Certain Expenses.#83944
Krishna2323 wants to merge 7 commits intoExpensify:mainfrom
Krishna2323:krishna2323/issue/81195

Conversation

@Krishna2323
Copy link
Contributor

@Krishna2323 Krishna2323 commented Mar 2, 2026

Explanation of Change

Fixed Issues

$ #81195
PROPOSAL: #81195 (comment)

Tests

  • Same as QA Steps

  • Verify that no errors appear in the JS console

Offline tests

  • Requires internet connection

QA Steps

Precondition: Maximize visible fields - Create an expense on a workspace that has categories, multiple tag levels, tax tracking, and attendee tracking all enabled. Fill in all fields, attach a receipt with long description, and add multiple tags

  1. Open Chrome DevTools
  2. Go to Troubleshoot page > Clear cache and restart
  3. Go to the Network tab
  4. Change throttling from "No throttling" to "Slow 3G"
  5. Navigate to Search → Reports tab
  6. Click on any expense report to open it in the RHP
  7. While the loading skeleton/spinner is still visible (or just after it disappears but API is still in-flight), try to scroll the expense details
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
android_native.mp4
Android: mWeb Chrome
android_chrome.mp4
iOS: Native
ios_native.mp4
iOS: mWeb Safari
ios_safari.mp4
MacOS: Chrome / Safari
web_chrome.mp4

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2026

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2026

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #83944.

Android 🤖 iOS 🍎
⏩ SKIPPED ⏩ ⏩ SKIPPED ⏩
The build for Android was skipped The build for iOS was skipped
Web 🕸️
https://83944.pr-testing.expensify.com
Web

👀 View the workflow run that generated this build 👀

@mountiny
Copy link
Contributor

mountiny commented Mar 2, 2026

Nice, confirmed that this works well on the affected report, lets get the PR ready for a review

@Krishna2323

This comment was marked as outdated.

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
@Krishna2323

This comment was marked as outdated.

@Krishna2323
Copy link
Contributor Author

I’ll continue working/testing on this tomorrow. I ran into an Android issue and had to change the approach.

@codecov
Copy link

codecov bot commented Mar 3, 2026

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/pages/inbox/report/ReportActionsList.tsx 78.78% <100.00%> (+0.06%) ⬆️
... and 11 files with indirect coverage changes

@mountiny
Copy link
Contributor

mountiny commented Mar 5, 2026

@Krishna2323 how is this looking

@Krishna2323
Copy link
Contributor Author

I'm on it, trying to fix the native issue:

image

…fic preview

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
@Krishna2323
Copy link
Contributor Author

@codex review

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6fab9d8d3c

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines +13 to +15
<View style={[styles.pt4]}>
<ScrollView>{children}</ScrollView>
</View>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Bound native preview scroll area

On iOS/Android this preview uses <View style={[styles.pt4]}> with a child <ScrollView> that has no explicit height/flex constraint, while ReportActionsList now forces the backing InvertedFlatList to flex0 during shouldScrollToEndAfterLayout. For long expense details, this makes the preview expand with its content instead of becoming a bounded scroll region, so users cannot reliably scroll through the RHP content in that loading state.

Useful? React with 👍 / 👎.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The native preview is bounded by its parent View which has flex: 1 and the sibling InvertedFlatList collapsed to flex: 0 during loading. The wrapper View provides the layout frame and the ScrollView inside handles scrolling when content overflows. Tested on both iOS and Android — scrolling works correctly for long expense details during the loading phase.

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
@Krishna2323 Krishna2323 marked this pull request as ready for review March 6, 2026 02:10
@Krishna2323 Krishna2323 requested review from a team as code owners March 6, 2026 02:10
@melvin-bot melvin-bot bot requested review from eVoloshchak and removed request for a team March 6, 2026 02:10
@melvin-bot
Copy link

melvin-bot bot commented Mar 6, 2026

@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot requested review from joekaufmanexpensify and removed request for a team March 6, 2026 02:10
@Krishna2323
Copy link
Contributor Author

@eVoloshchak this will require a very thorough review from your side. I’ve done as much testing as I could, but this would need a thorough second pair of eyes since this could potentially cause regressions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants