fix: Unable to Scroll in Right-Hand Panel (RHP) for Certain Expenses.#83944
fix: Unable to Scroll in Right-Hand Panel (RHP) for Certain Expenses.#83944Krishna2323 wants to merge 7 commits intoExpensify:mainfrom
Conversation
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
Nice, confirmed that this works well on the affected report, lets get the PR ready for a review |
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
This comment was marked as outdated.
This comment was marked as outdated.
|
I’ll continue working/testing on this tomorrow. I ran into an Android issue and had to change the approach. |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
|
@Krishna2323 how is this looking |
…fic preview Signed-off-by: krishna2323 <belivethatkg@gmail.com>
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6fab9d8d3c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| <View style={[styles.pt4]}> | ||
| <ScrollView>{children}</ScrollView> | ||
| </View> |
There was a problem hiding this comment.
Bound native preview scroll area
On iOS/Android this preview uses <View style={[styles.pt4]}> with a child <ScrollView> that has no explicit height/flex constraint, while ReportActionsList now forces the backing InvertedFlatList to flex0 during shouldScrollToEndAfterLayout. For long expense details, this makes the preview expand with its content instead of becoming a bounded scroll region, so users cannot reliably scroll through the RHP content in that loading state.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
The native preview is bounded by its parent View which has flex: 1 and the sibling InvertedFlatList collapsed to flex: 0 during loading. The wrapper View provides the layout frame and the ScrollView inside handles scrolling when content overflows. Tested on both iOS and Android — scrolling works correctly for long expense details during the loading phase.
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
|
@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@eVoloshchak this will require a very thorough review from your side. I’ve done as much testing as I could, but this would need a thorough second pair of eyes since this could potentially cause regressions. |

Explanation of Change
Fixed Issues
$ #81195
PROPOSAL: #81195 (comment)
Tests
Same as QA Steps
Verify that no errors appear in the JS console
Offline tests
QA Steps
Precondition: Maximize visible fields - Create an expense on a workspace that has categories, multiple tag levels, tax tracking, and attendee tracking all enabled. Fill in all fields, attach a receipt with long description, and add multiple tags
Troubleshootpage > Clear cache and restartPR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android_native.mp4
Android: mWeb Chrome
android_chrome.mp4
iOS: Native
ios_native.mp4
iOS: mWeb Safari
ios_safari.mp4
MacOS: Chrome / Safari
web_chrome.mp4