[No-QA] chore: [Performance] Optimize useFilterFormValues (~16ms per render) by TaduJR · Pull Request #83746 · Expensify/App

TaduJR · 2026-02-27T19:11:37Z

Explanation of Change

useFilterFormValues was called in both SearchPage and SearchFiltersBar, creating 12 Onyx collection subscriptions (6 each) and running buildFilterFormValuesFromQuery twice per render. This PR:

Removes the duplicate hook call from SearchPage — keeps it only in SearchFiltersBar, which is the sole consumer. The useEffect that syncs updateAdvancedFilters moves there too.
Adds Onyx selectors to the 4 collection subscriptions in useFilterFormValues — each selector extracts only the fields that buildFilterFormValuesFromQuery actually reads:
- COLLECTION.POLICY → only taxRates (strips employeeList, customUnits, etc.)
- COLLECTION.REPORT → only reportID
- COLLECTION.POLICY_CATEGORIES → only name per category
- COLLECTION.POLICY_TAGS → only name per tag

This makes Onyx's deepEqual compare small selector output instead of full collection objects on every update.

Fixed Issues

$ #82421
PROPOSAL: #82421 (comment)

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

melvin-bot · 2026-02-27T19:11:44Z

@jayeshmangwani Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

luacmartins · 2026-02-27T19:14:06Z

@TaduJR can you provide measurements on the performance improvement please?

luacmartins · 2026-02-27T19:15:10Z

We also have several lint issues on SearchPage. A lot of that logic was removed already

TaduJR · 2026-02-27T19:17:33Z

@TaduJR can you provide measurements on the performance improvement please?

Sure.

We also have several lint issues on SearchPage. A lot of that logic was removed already

Hmm I think they are occurring after merging with main. Let me check

codecov · 2026-02-27T19:20:24Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/hooks/useFilterFormValues.tsx	`100.00% <100.00%> (ø)`
src/libs/PolicyUtils.ts	`57.59% <100.00%> (+12.07%)`	⬆️
src/libs/SearchQueryUtils.ts	`72.61% <46.15%> (+1.02%)`	⬆️
... and 158 files with indirect coverage changes

src/hooks/useFilterFormValues.tsx

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b28ed1fb66

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/components/Search/SearchPageHeader/SearchFiltersBar.tsx

luacmartins · 2026-03-02T20:14:56Z

@TaduJR let's resolve conflicts and mark the PR as ready for review please

…rmance-OptimizeuseFilterFormValues-16ms-per-render # Conflicts: # src/components/Search/SearchPageHeader/SearchFiltersBar.tsx

…rmance-OptimizeuseFilterFormValues-16ms-per-render

… perf test

TaduJR · 2026-03-04T00:15:16Z

@TaduJR can you provide measurements on the performance improvement please?

Test	Renders
With `policiesSelector`	-50.0%

TaduJR · 2026-03-05T16:14:07Z

All good @luacmartins?

luacmartins · 2026-03-05T17:18:03Z

@TaduJR can you provide additional metrics for the actual time it takes to run the hook now?

luacmartins · 2026-03-05T17:18:19Z

@jayeshmangwani please prioritize this review when you're online

TaduJR · 2026-03-05T17:21:14Z

@TaduJR can you provide additional metrics for the actual time it takes to run the hook now?

Sure @luacmartins. I will provide today.

…rmance-OptimizeuseFilterFormValues-16ms-per-render

…AndKeys with algorithmic improvements

…QueryJSONOrThrow helper

…s before filter loop

TaduJR · 2026-03-05T21:50:59Z

buildFilterFormValuesFromQuery — Algorithmic Optimization

Metric	main (baseline)	PR (current)	Change
Duration	5.6 ms	2.1 ms	-3.5 ms (-61.9%) 🟢

Render Count — Selectors Prevent Re-renders

Test	Render Count	Change
With selectors (full hook simulation)	2 → 1 (-1, -50.0%) 🟢	Selector prevents re-render
With policiesSelector (isolated)	2 → 1 (-1, -50.0%) 🟢	Selector prevents re-render

jayeshmangwani · 2026-03-06T13:07:00Z

Hi @luacmartins , sorry for the delay. I won’t be able to review this PR today, but I can check it tomorrow if it’s not urgent. If it is urgent, I can ask in the C+ channel to reassign it in case someone wants to take it.

luacmartins · 2026-03-06T16:06:53Z

Asked for a reassingment

Pujan92 · 2026-03-06T16:53:15Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

luacmartins

LGTM

Pujan92 · 2026-03-06T17:57:46Z

src/hooks/useFilterFormValues.tsx

 };

 export default useFilterFormValues;
+export {policiesSelector, reportsSelector, policyCategoriesSelector, policyTagsSelector};


Suggested change

export {policiesSelector, reportsSelector, policyCategoriesSelector, policyTagsSelector};

Do we really need to export?

I assume this is for the tests

Pujan92 · 2026-03-06T17:59:00Z

src/hooks/useFilterFormValues.tsx

+            if (!category) {
+                continue;
+            }


Suggested change

if (!category) {

continue;

}

I think we don't need this check and same for tag too as it won't be undefined as per the type

Pujan92 · 2026-03-06T18:15:10Z

Change 1: Deduplicate the hook — remove it from SearchPage, keep it only in SearchFiltersBar.

Remove the useFilterFormValues call and its useEffect sync from SearchPage.tsx. Move the updateAdvancedFilters(formValues, true) sync into SearchFiltersBar.tsx where the hook already exists. This eliminates 6 duplicate Onyx subscriptions and halves buildFilterFormValuesFromQuery execution.

@TaduJR Aren't we implementing the suggested change in your proposal of using useSearchFilterSync(filterFormValues); to avoid it in SearchPage?

App/src/components/Search/SearchPageHeader/useSearchFiltersBar.tsx

Line 89 in 3bc719c

const filterFormValues = useFilterFormValues(queryJSON);

chore: [Performance] Optimize useFilterFormValues (~16ms per render)

b28ed1f

TaduJR requested review from a team as code owners February 27, 2026 19:11

melvin-bot bot assigned TaduJR Feb 27, 2026

melvin-bot bot requested a review from jayeshmangwani February 27, 2026 19:11

melvin-bot bot requested review from heyjennahay and removed request for a team February 27, 2026 19:11

github-actions bot reviewed Feb 27, 2026

View reviewed changes

src/hooks/useFilterFormValues.tsx Show resolved Hide resolved

fix: resolve merge conflicts and remove unused imports from SearchPage

9f491ff

chatgpt-codex-connector bot reviewed Feb 27, 2026

View reviewed changes

src/components/Search/SearchPageHeader/SearchFiltersBar.tsx Outdated Show resolved Hide resolved

test: add unit tests for useFilterFormValues selectors

75b9643

TaduJR marked this pull request as draft February 27, 2026 20:26

luacmartins self-requested a review March 2, 2026 20:14

TaduJR added 5 commits March 4, 2026 01:31

Merge branch 'main' of https://github.com/TaduJR/App into chore-Perfo…

88d5a51

…rmance-OptimizeuseFilterFormValues-16ms-per-render # Conflicts: # src/components/Search/SearchPageHeader/SearchFiltersBar.tsx

fix: OnyxCollection type errors in tests

853c86c

test: add Reassure perf test for useFilterFormValues selectors

054d6ee

Merge branch 'main' of https://github.com/TaduJR/App into chore-Perfo…

d271970

…rmance-OptimizeuseFilterFormValues-16ms-per-render

fix: add missing taxRates fields and remove unused lint suppressor in…

31fc504

… perf test

TaduJR marked this pull request as ready for review March 4, 2026 00:23

TaduJR added 4 commits March 5, 2026 23:03

Merge branch 'main' of https://github.com/TaduJR/App into chore-Perfo…

9c0d425

…rmance-OptimizeuseFilterFormValues-16ms-per-render

perf: optimize buildFilterFormValuesFromQuery and getAllTaxRatesNames…

3f1b8c6

…AndKeys with algorithmic improvements

fix: resolve TypeScript errors in perf test by extracting buildSearch…

cf6f26e

…QueryJSONOrThrow helper

perf: hoist constant Sets to module level and pre-compute dynamic Set…

b8de7a3

…s before filter loop

luacmartins requested review from Pujan92 and removed request for jayeshmangwani March 6, 2026 16:06

luacmartins approved these changes Mar 6, 2026

View reviewed changes

Pujan92 reviewed Mar 6, 2026

View reviewed changes

Conversation

TaduJR commented Feb 27, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Feb 27, 2026

Uh oh!

luacmartins commented Feb 27, 2026

Uh oh!

luacmartins commented Feb 27, 2026

Uh oh!

TaduJR commented Feb 27, 2026

Uh oh!

codecov bot commented Feb 27, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

luacmartins commented Mar 2, 2026

Uh oh!

TaduJR commented Mar 4, 2026

Uh oh!

TaduJR commented Mar 5, 2026

Uh oh!

luacmartins commented Mar 5, 2026

Uh oh!

luacmartins commented Mar 5, 2026

Uh oh!

TaduJR commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TaduJR commented Mar 5, 2026

buildFilterFormValuesFromQuery — Algorithmic Optimization

Render Count — Selectors Prevent Re-renders

Uh oh!

jayeshmangwani commented Mar 6, 2026

Uh oh!

luacmartins commented Mar 6, 2026

Uh oh!

Pujan92 commented Mar 6, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

Pujan92 Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

luacmartins Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

Pujan92 Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

Pujan92 commented Mar 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Feb 27, 2026 •

edited by github-actions bot

Loading

TaduJR commented Mar 5, 2026 •

edited

Loading