Add missing warning modals for re-exporting and retracting exported reports#82885
Draft
Add missing warning modals for re-exporting and retracting exported reports#82885
Conversation
…eports Set isExportedToIntegration optimistically in both exportToIntegration and markAsManuallyExported so the isExported check returns true immediately. Add isExported guard to the RETRACT action matching the existing REOPEN pattern. Co-authored-by: parasharrajat <parasharrajat@users.noreply.github.com>
Contributor
Author
|
I created this PR from an upstream branch since I don't have push access to your fork. To take ownership of this branch and be able to push updates, run: Then you can close this PR and open a new one from your fork. |
7 tasks
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
When a report has already been exported (via "Mark as exported" or "Export to integration"), two warning modals were not appearing:
"Careful!" re-export modal — The
markAsManuallyExportedandexportToIntegrationfunctions were not optimistically settingreport.isExportedToIntegration = true, so theisExportedcheck short-circuited tofalsebefore the server confirmed the export. This meant the re-export warning modal was never triggered."Reopen report" modal on Retract — The
RETRACTsecondary action handler calledretractReport()directly without checkingisExported, unlike the adjacentREOPENandUNAPPROVEhandlers which both show confirmation modals for exported reports.This PR fixes both issues by:
isExportedToIntegration: trueto bothexportToIntegrationandmarkAsManuallyExported(withfalsein failure data to revert on error)isExportedguard to theRETRACTaction handler, following the same pattern asREOPENFixed Issues
$ #82745
Tests
Precondition: Workspace connected to an accounting integration (e.g. Sage Intacct), Approvals and Payments disabled in Workflows.
Offline tests
QA Steps
Same as Tests above.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari