[NO QA] Fix Concierge AI icon styling on new-expensify/hubs#82870
[NO QA] Fix Concierge AI icon styling on new-expensify/hubs#82870luacmartins merged 2 commits intomainfrom
Conversation
…pecific icon dimensions.
|
@luacmartins Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
A preview of your ExpensifyHelp changes have been deployed to https://7d1d0901.helpdot.pages.dev ⚡️ |
|
@luacmartins Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
geeeez |
|
@MelvinBot it's too small now. please use hub card styling. a simpler fix. and for search page, use different size using css selector if necessary |
Replace the SVG-specific selector targeting only the concierge bot icon with a general .hub-card .icon rule at 68px (matching the intrinsic size of other hub card SVGs). Remove the conditional platform class from platform.html since it's no longer needed. Co-authored-by: Rushat Gabhane <rushatgabhane@users.noreply.github.com>
|
Updated the approach per your feedback. The changes:
This ensures all hub card icons render consistently at the same size. The concierge bot SVG was the only one missing explicit width/height attributes in the SVG, so it was the only one affected — but now all icons go through the same The search page's concierge illustration is unaffected — it uses the |
Reviewer Checklist
Screenshots/Videos
|
|
🚀 Deployed to staging by https://github.com/luacmartins in version: 9.3.23-2 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.3.23-3 🚀
|



Explanation of Change
Fixed Concierge AI icon styling on new-expensify/hubs so it renders the same size as the other icons on the page.
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari