Skip to content

Comments

Filter Expensify team members from workspace members CSV export#82866

Closed
MelvinBot wants to merge 3 commits intomainfrom
claude-filterExpensifyTeamFromMembersCSV
Closed

Filter Expensify team members from workspace members CSV export#82866
MelvinBot wants to merge 3 commits intomainfrom
claude-filterExpensifyTeamFromMembersCSV

Conversation

@MelvinBot
Copy link
Contributor

Explanation of Change

The workspace members CSV export in New Expensify includes Expensify account managers (e.g., @expensify.com and @team.expensify.com emails) in the exported file, even though they are filtered from the members list UI. Classic Expensify filters these members in both views.

This PR builds the CSV client-side on web when the employee list data is available, applying the same isExpensifyTeam() filtering that the members list UI uses. On native platforms (or when data is unavailable), it falls back to the existing server-side ExportMembersCSV API.

Changes:

  • Added escapeCSVField() helper for proper CSV field escaping
  • Added buildFilteredMembersCSV() that constructs the CSV while filtering out Expensify team members (unless the policy owner or current user is on an Expensify domain)
  • Updated downloadMembersCSV() to accept employee list data and generate the CSV client-side on web
  • Updated call site in WorkspaceMembersPage.tsx to pass the required data

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/600539

Tests

  1. Navigate to a workspace that has an Expensify account manager assigned
  2. Go to Members page — verify the account manager is NOT shown in the list
  3. Click the three-dot menu and select "Download CSV"
  4. Open the downloaded CSV file
  5. Verify the account manager email (e.g., @expensify.com or @team.expensify.com) does NOT appear in the CSV
  6. For a workspace owned by an @expensify.com email, repeat steps 2-5 and verify Expensify team members ARE included (since the owner is on an Expensify domain)
  • Verify that no errors appear in the JS console

Offline tests

When offline, the download button should be disabled (existing behavior, unchanged by this PR). The client-side CSV generation does not make network requests, but the button is already gated by isOffline.

QA Steps

  1. Log in to a workspace that has an Expensify account manager
  2. Navigate to Settings > Workspaces > [Workspace] > Members
  3. Tap the three-dot menu > Download CSV
  4. Open the CSV and verify no @expensify.com or @team.expensify.com emails appear
  5. Repeat with a workspace owned by an @expensify.com account and verify Expensify team members are included
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

N/A — No UI changes, only CSV export content filtering

Android: mWeb Chrome

N/A — No UI changes, only CSV export content filtering

iOS: Native

N/A — No UI changes, only CSV export content filtering

iOS: mWeb Safari

N/A — No UI changes, only CSV export content filtering

MacOS: Chrome / Safari

N/A — No UI changes, only CSV export content filtering

Build the members CSV client-side when employee list data is available,
applying the same isExpensifyTeam filtering that the member list UI
already uses. This prevents @expensify.com and @team.expensify.com
accounts (such as account managers) from appearing in the exported CSV.

Co-authored-by: Lydia Barclay <lydiabarclay@users.noreply.github.com>
@MelvinBot MelvinBot requested a review from a team February 18, 2026 22:29
Co-authored-by: Lydia Barclay <lydiabarclay@users.noreply.github.com>
@MelvinBot
Copy link
Contributor Author

Fixed the failing Prettier check. The long import line in Member.ts, the downloadMembersCSV function signature, and the useMemo dependency array in WorkspaceMembersPage.tsx needed to be broken into multi-line format per the project's Prettier configuration.

…t rule

Co-authored-by: Lydia Barclay <lydiabarclay@users.noreply.github.com>
@MelvinBot
Copy link
Contributor Author

Fixed the failing Changed files ESLint check. The no-default-id-values rule was flagging employee.employeeUserID ?? '' and employee.employeePayrollID ?? '' on lines 1361-1362 of src/libs/actions/Policy/Member.ts because ID fields must not be defaulted with ??. Changed them to use ternary expressions (employee.employeeUserID ? String(employee.employeeUserID) : '') which avoids the defaulting pattern while still producing empty strings in the CSV for missing values.

@codecov
Copy link

codecov bot commented Feb 18, 2026

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/pages/workspace/WorkspaceMembersPage.tsx 61.32% <ø> (ø)
src/libs/actions/Policy/Member.ts 66.01% <0.00%> (-6.18%) ⬇️
... and 10 files with indirect coverage changes

@cead22
Copy link
Contributor

cead22 commented Feb 20, 2026

Seeing what this updated and the new logic, I think this change should be in the backend. I asked Melvin in the issue to make the relevant changes

@cead22 cead22 closed this Feb 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants