Reduce search filters bar re-renders by luacmartins · Pull Request #82846 · Expensify/App

luacmartins · 2026-02-18T17:57:47Z

Explanation of Change

This PR does a few things:

Stabilizes the refence to the confirmPayment function to avoid re-renders of the SearchFiltersBar component.
Updates the code in DatePickerFilterPopup to allow React compiler to auto memoize SearchFiltersBar
Removes instances of useMemo and useCallback since the component is memoized by React compiler
Moves DatePickerFilterPopup outside SearchFiltersBar

Fixed Issues

Tests

Enabled Sentry spans on dev
Supportalled into applausetester@applause.expensifail.com
Manually navigated back and forth between the Inbox and Reports page
Measured the average time for the ManualNavigateToReportsTab span in Sentry
Got the results below

Branch	Avg time (ms)	Sentry link
main	849.88ms	Link
this branch	787.31ms	Link

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

N/A

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

- Add onBulkPaySelectedRef and keep it updated with latest onBulkPaySelected - Expose stableOnBulkPaySelected (useCallback with empty deps) that invokes ref.current - Pass stableOnBulkPaySelected to SearchPageNarrow (confirmPayment) and SearchPageWide (onBulkPaySelected) - Reduces SearchFiltersBar re-renders caused by unstable confirmPayment prop (plan step 1) Co-authored-by: Cursor <cursoragent@cursor.com>

codecov · 2026-02-18T18:06:36Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/pages/Search/SearchPage.tsx	`23.30% <75.00%> (+0.40%)`	⬆️
...nents/Search/SearchPageHeader/SearchFiltersBar.tsx	`65.28% <60.27%> (-0.41%)`	⬇️
... and 14 files with indirect coverage changes

melvin-bot · 2026-02-18T20:14:52Z

@dominictb Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dominictb · 2026-02-18T20:15:53Z

@luacmartins please reassign

situchan · 2026-02-18T20:17:11Z

I can help review

src/components/Search/SearchPageHeader/SearchFiltersBar.tsx

situchan · 2026-02-19T00:30:49Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

ios.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mov

bulk pay:

Screen.Recording.2026-02-19.at.11.39.16.PM.mov

situchan · 2026-02-19T00:30:53Z

Please fix conflict (came from #81659)

src/components/Search/SearchPageHeader/SearchFiltersBar.tsx

szymonzalarski98 · 2026-02-19T06:17:31Z

PR looks good :)

joekaufmanexpensify · 2026-02-19T14:48:41Z

No product review needed

luacmartins · 2026-02-19T17:26:26Z

Updated

melvin-bot · 2026-02-19T17:41:11Z

@grgia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector · 2026-02-19T21:38:09Z

Codex Review: Didn't find any major issues. Keep it up!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

grgia · 2026-02-20T11:21:09Z

src/components/Search/SearchPageHeader/SearchFiltersBar.tsx

+    const isOptions = Object.values(CONST.SEARCH.IS_VALUES).map((value) => ({text: translate(`common.${value}`), value}));
+    const is = isFilterValues ? isOptions.filter((option) => isFilterValues.includes(option.value)) : [];
+
+    const createDateDisplayValue = (filterValues: {on?: string; after?: string; before?: string}): [SearchDateValues, string[]] => {


createDateDisplayValue is a pure function. Could it move outside the component like DatePickerFilterPopup and MultiSelectFilterPopup?

Yea, we can. I'll do that in a follow up. Thanks!

Hmm actually it's not pure since it takes translate from the hook. I'll keep it in for now

github-actions · 2026-02-20T15:58:23Z

🚧 @luacmartins has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-02-20T16:02:07Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #82846.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-9e92eea-ff072f6-cf3d76cc65b828b994325f02aa8f9b4e3de5f620/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-9e92eea-ff072f6-af0ca75e0b7636dd5fbf79b4a39dbafa02cc374a/index.html

Web 🕸️
https://82846.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-02-20T16:43:55Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.3.24-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

IuliiaHerets · 2026-02-20T17:49:26Z

Hi @luacmartins. Is it an internal QA?

luacmartins · 2026-02-20T18:01:19Z

No QA

IuliiaHerets · 2026-02-20T18:05:13Z

@luacmartins I can check it off then, right?

luacmartins · 2026-02-20T18:15:29Z

@IuliiaHerets yes, I already did

OSBotify · 2026-02-23T21:45:37Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.3.24-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

luacmartins and others added 4 commits February 18, 2026 10:10

React compiler

3929672

remove useMemo, useCallback

141e29b

Reafactor component factories

3c01ff0

luacmartins self-assigned this Feb 18, 2026

Fix prettier

4b54d7c

luacmartins marked this pull request as ready for review February 18, 2026 20:14

luacmartins requested review from a team as code owners February 18, 2026 20:14

melvin-bot bot requested review from dominictb and joekaufmanexpensify and removed request for a team February 18, 2026 20:14

luacmartins requested review from situchan and szymonzalarski98 and removed request for dominictb February 18, 2026 20:20

situchan reviewed Feb 18, 2026

View reviewed changes

src/components/Search/SearchPageHeader/SearchFiltersBar.tsx Outdated Show resolved Hide resolved

szymonzalarski98 approved these changes Feb 19, 2026

View reviewed changes

src/components/Search/SearchPageHeader/SearchFiltersBar.tsx Show resolved Hide resolved

joekaufmanexpensify removed their request for review February 19, 2026 14:48

Resolve conflicts

5644c97

luacmartins requested a review from situchan February 19, 2026 17:25

situchan approved these changes Feb 19, 2026

View reviewed changes

melvin-bot bot requested a review from grgia February 19, 2026 17:41

grgia reviewed Feb 20, 2026

View reviewed changes

grgia approved these changes Feb 20, 2026

View reviewed changes

luacmartins merged commit 9e92eea into main Feb 20, 2026
35 checks passed

luacmartins deleted the cmartins-reduceSearchFiltersBarRerenders branch February 20, 2026 15:57

OSBotify mentioned this pull request Feb 20, 2026

Deploy Checklist: New Expensify 2026-02-20 #83077

Closed

67 tasks

MelvinBot mentioned this pull request Feb 20, 2026

[Performance] Reduce re-renders for SearchFiltersBar #82419

Open

Conversation

luacmartins commented Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Feb 18, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Feb 18, 2026

Uh oh!

dominictb commented Feb 18, 2026

Uh oh!

situchan commented Feb 18, 2026

Uh oh!

Uh oh!

situchan commented Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

situchan commented Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

szymonzalarski98 commented Feb 19, 2026

Uh oh!

joekaufmanexpensify commented Feb 19, 2026

Uh oh!

luacmartins commented Feb 19, 2026

Uh oh!

melvin-bot bot commented Feb 19, 2026

Uh oh!

chatgpt-codex-connector bot commented Feb 19, 2026

Uh oh!

grgia Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

luacmartins Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

luacmartins Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Feb 20, 2026

Uh oh!

github-actions bot commented Feb 20, 2026

Uh oh!

OSBotify commented Feb 20, 2026

Uh oh!

IuliiaHerets commented Feb 20, 2026

Uh oh!

luacmartins commented Feb 20, 2026

Uh oh!

IuliiaHerets commented Feb 20, 2026

Uh oh!

luacmartins commented Feb 20, 2026

Uh oh!

OSBotify commented Feb 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

luacmartins commented Feb 18, 2026 •

edited

Loading

codecov bot commented Feb 18, 2026 •

edited by github-actions bot

Loading

situchan commented Feb 19, 2026 •

edited

Loading

situchan commented Feb 19, 2026 •

edited

Loading