[No QA] Chore: keep consistent naming in SelectionList and SelectionListWithSections by sharabai · Pull Request #82839 · Expensify/App

sharabai · 2026-02-18T17:15:27Z

Explanation of Change

Use good variable nomenclature in new SelectionList and SelectionListWithSections components.
Per this contributing guide rule:
vars with boolean values should start with prefix 'should'. To be consistent with that rule a prop name was changed as well as var names, which values were passed.

Changes made:
showLoadingPlaceholder - > shouldShowLoadingPlaceholder
showEmptyContent - > shouldShowEmptyContent

Fixed Issues

$ #65658
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified there are no new alerts related to the canBeMissing param for useOnyx
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

codecov · 2026-02-18T17:25:33Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/CONST/index.ts	`87.39% <ø> (ø)`
src/components/ApproverSelectionList.tsx	`0.00% <ø> (ø)`
src/components/CurrencySelectionList/index.tsx	`0.00% <ø> (ø)`
src/components/MoneyRequestConfirmationList.tsx	`59.86% <ø> (ø)`
...nents/Search/FilterDropdowns/SingleSelectPopup.tsx	`0.00% <ø> (ø)`
src/components/Search/SearchAutocompleteList.tsx	`39.20% <ø> (ø)`
...omponents/Search/SearchMultipleSelectionPicker.tsx	`0.00% <ø> (ø)`
.../components/Search/SearchSingleSelectionPicker.tsx	`0.00% <ø> (ø)`
src/components/SelectionList/BaseSelectionList.tsx	`70.85% <100.00%> (ø)`
...ts/SelectionList/ListItem/InviteMemberListItem.tsx	`91.42% <ø> (ø)`
... and 46 more
... and 34 files with indirect coverage changes

sharabai · 2026-02-18T18:22:02Z

Ignore failing ESLint CI check — it warns to add sentry labels to a PressableWithFeedback components, but it doesn't make to add those in a PR that is focused on naming convention refactor mainly.

zfurtak · 2026-02-18T19:43:18Z

src/components/SelectionListWithSections/BaseSelectionListWithSections.tsx

    listEmptyContent,
    showScrollIndicator = true,
-    showLoadingPlaceholder = false,
+    shouldShowLoadingPlaceholder = false,


I don't think changing it here makes sense, we'll be removing this file in a week

@zfurtak I agree, but if since it's gonna be removed anyway, any changes to it doesn't matter that much. Reverting those changes'd be a waste of time as much as applying them.

zfurtak · 2026-02-18T19:43:48Z

src/components/SelectionList/SelectionListWithSections/BaseSelectionListWithSections.tsx

    canSelectMultiple = false,
-    showLoadingPlaceholder = false,
+    shouldShowLoadingPlaceholder = false,
    showListEmptyContent = true,


What about this props, I think we should change it as well

Suggested change

showListEmptyContent = true,

shouldShowListEmptyContent = true,

@zfurtak absolutely makes sense! Great catch!

zfurtak · 2026-02-19T14:29:30Z

src/components/SelectionList/types.ts

 type ButtonOrCheckBoxRoles = 'button' | 'checkbox';

-type SelectionListHandle<TItem extends ListItem> = {
+type SelectionListHandle<TItem extends ListItem = ListItem> = {


Why did you add it?

@zfurtak by mistake. It's in a commit that is from this PR.
I'll remove it in the original PR and rebase this one.
I originally didn't change SelectionListHandle to SelectionListWithSectionsHandle and added that default type. Later I used the correct type, but forgot about that change! Great catch! 🏅

…MoneyRequestParticipantsSelector

…SectionList and SectionListWithSections

melvin-bot bot assigned sharabai Feb 18, 2026

sharabai changed the title ~~Chore: keep consistent naming in SectionList and SectionListWithSections~~ [No QA] Chore: keep consistent naming in SectionList and SectionListWithSections Feb 18, 2026

zfurtak reviewed Feb 18, 2026

View reviewed changes

sharabai force-pushed the chore/keep-consistent-naming-in-SectionList-and-SectionListWithSections branch 2 times, most recently from b8a75ce to 75c66d9 Compare February 19, 2026 12:38

sharabai requested a review from zfurtak February 19, 2026 13:41

zfurtak approved these changes Feb 19, 2026

View reviewed changes

sharabai changed the title ~~[No QA] Chore: keep consistent naming in SectionList and SectionListWithSections~~ [No QA] Chore: keep consistent naming in SelectionList and SelectionListWithSections Feb 19, 2026

sharabai force-pushed the chore/keep-consistent-naming-in-SectionList-and-SectionListWithSections branch from 75c66d9 to 2876842 Compare February 19, 2026 16:34

sharabai added 2 commits February 19, 2026 17:35

chore: migrate old SelectionList to new SelectionListWithSections in …

b50098e

…MoneyRequestParticipantsSelector

chore: change names according to should-boolean-prefix convention in …

07a37e5

…SectionList and SectionListWithSections

sharabai force-pushed the chore/keep-consistent-naming-in-SectionList-and-SectionListWithSections branch from 2876842 to 07a37e5 Compare February 19, 2026 16:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

[No QA] Chore: keep consistent naming in SelectionList and SelectionListWithSections#82839

[No QA] Chore: keep consistent naming in SelectionList and SelectionListWithSections#82839
sharabai wants to merge 2 commits intoExpensify:mainfrom
software-mansion-labs:chore/keep-consistent-naming-in-SectionList-and-SectionListWithSections

sharabai commented Feb 18, 2026 •

edited

Loading

Uh oh!

codecov bot commented Feb 18, 2026 •

edited by github-actions bot

Loading

Uh oh!

sharabai commented Feb 18, 2026 •

edited

Loading

Uh oh!

zfurtak Feb 18, 2026

Uh oh!

sharabai Feb 19, 2026

Uh oh!

zfurtak Feb 18, 2026

Uh oh!

sharabai Feb 19, 2026

Uh oh!

zfurtak Feb 19, 2026

Uh oh!

sharabai Feb 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	showListEmptyContent = true,
	shouldShowListEmptyContent = true,

Comments

Conversation

sharabai commented Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Feb 18, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sharabai commented Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zfurtak Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

sharabai Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

zfurtak Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

sharabai Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

zfurtak Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

sharabai Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sharabai commented Feb 18, 2026 •

edited

Loading

codecov bot commented Feb 18, 2026 •

edited by github-actions bot

Loading

sharabai commented Feb 18, 2026 •

edited

Loading