-
Notifications
You must be signed in to change notification settings - Fork 3.5k
remove ONYXKEYS.ONBOARDING_COMPANY_SIZE in src/libs/ReportUtils.ts #78623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@hungvu193 Could you verify again that we’re not missing the companySize parameter in any createWorkspace usage (If needed)? |
|
@hungvu193 How about the missing new param here? Is this intentional?
|
Yep. |
|
@hungvu193 To be safe, we should clear reasons in all cases where we skip passing the companySize parameter. Right now, it’s missing in many places without a clear reason, which I think is risky. |
So probably we should leave a comment to explain when |
|
@hungvu193 No, I mean that we have some missing places. But I want we should verify that all missing places are intentional |


Explanation of Change
Remove
Onyx.connectforONYXKEYS.ONBOARDING_COMPANY_SIZEinReportUtils.ts.Fixed Issues
$ #66429
PROPOSAL: N/A
Tests
Same as QA Tests.
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Manage my team expenses> Choose any option.CompleteGuidedSetupis called with the correctcompanySizeparam.PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2025-12-31.at.13.52.13.mov