fix: apple login page overlaps device status bar #74775

NJ-2020 · 2025-11-11T07:05:25Z

Explanation of Change

Fx apple login page overlaps device status bar by passing fullScreen: false to the android configuration
Upstream PR: feat(android): introduce new prop fullScreen to adjust dialog screen size invertase/react-native-apple-authentication#378

Fixed Issues

$ #64116
PROPOSAL: #64116 (comment)

Tests

Open Expensify App
Sign out if signed in
Tap Apple login
Verify that the Apple login page does not overlaps device status bar
Sign in with Apple credentials
The account data should exist and work as expected

Verify that no errors appear in the JS console

Offline tests

This tests requires internet connection

QA Steps

QA and InternalQA test steps Both Android and iOS

Open Expensify App
Sign out if signed in
Tap Apple login
Verify that the Apple login page does not overlaps device status bar (iOS only)
Sign in with Apple credentials
The account data should exist and work as expected

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-11-15.at.14.20.00.mov

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

…rsion

github-actions · 2025-11-11T07:05:34Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

codecov · 2025-11-11T07:17:28Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...onents/SignInButtons/AppleSignIn/index.android.tsx	`0.00% <0.00%> (ø)`
... and 4 files with indirect coverage changes

melvin-bot · 2025-11-15T07:24:37Z

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2025-11-15T07:24:42Z

@Julesssss Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

NJ-2020 · 2025-11-15T07:25:46Z

Screenshots/Videos

For IOS, I am having build issues, will complete it soon. Thanks

situchan · 2025-11-15T18:58:58Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

before:

android-before.mov

after:

android-after.mov

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

situchan · 2025-11-15T18:59:43Z

Sign in with apple doesn't work on iOS simulator. Stuck here after successful sign in: (also happening on main)

situchan

Android works well.

I think we need help from internal engineer for testing iOS in adhoc build.

cc: @Julesssss

github-actions · 2025-11-17T17:15:34Z

🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here.

Julesssss

Will test on iOS AdHoc

NJ-2020 · 2025-11-24T09:12:14Z

Sorry guys for the delay here, I am still having this error with my Xcode + IOS build, sometimes the error gone, but then after a while the error appear again

I've tried deleting Pods, /Xcode/DerivedData/, ios/build folder, but still the error still persists.

NJ-2020 · 2025-11-26T09:31:12Z

Still same ^, I am still debugging/fixing the bug, in the meanwhile, @Julesssss Could you please try another adhoc build and try again if the issue still occurs?. Many thanks

cc: @situchan

github-actions · 2025-11-26T17:35:10Z

🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2025-11-26T17:55:22Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #74775.

Android 🤖	iOS 🍎
⏩ SKIPPED ⏩	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/74775/index.html
The build for Android was skipped

Desktop 💻	Web 🕸️
N/A	⏩ SKIPPED ⏩
N/A	The build for Web was skipped

👀 View the workflow run that generated this build 👀

NJ-2020 · 2025-12-01T09:24:48Z

@Julesssss Any updates?

Julesssss · 2025-12-01T17:25:38Z

I forgot about this, my bad. I just retested but am getting the force upload modal due to the old app version. Would you mind re-merging main and I'll try again.

NJ-2020 · 2025-12-02T01:09:05Z

I forgot about this, my bad. I just retested but am getting the force upload modal due to the old app version. Would you mind re-merging main and I'll try again.

Done

github-actions · 2025-12-02T17:38:21Z

🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2025-12-02T18:03:19Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #74775.

Android 🤖	iOS 🍎
❌ FAILED ❌	❌ FAILED ❌
The QR code can't be generated, because the Android build failed	The QR code can't be generated, because the iOS build failed

Web 🕸️
https://74775.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

Julesssss

A couple of build errors: https://github.com/Expensify/App/actions/runs/19867933558/job/56935701287

NJ-2020 · 2025-12-03T10:01:27Z

A couple of build errors: https://github.com/Expensify/App/actions/runs/19867933558/job/56935701287

Fixed ☑️

github-actions · 2025-12-03T17:18:37Z

🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2025-12-03T17:46:42Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #74775.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/74775/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/74775/index.html

Web 🕸️
https://74775.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

Julesssss · 2025-12-03T18:40:31Z

Still same ^, I am still debugging/fixing the bug, in the meanwhile, @Julesssss Could you please try another adhoc build and try again if the issue still occurs?. Many thanks

Hmm yeah same issue. BUT I just checked another build and this seems to happen on all AdHoc builds 😕

Okay lets get this tested properly on a staging build.

OSBotify · 2025-12-03T19:09:18Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

NJ-2020 · 2025-12-04T00:35:09Z

Thanks

OSBotify · 2025-12-04T16:09:55Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.2.72-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Julesssss · 2025-12-04T20:59:25Z

Okay lets get this tested properly on a staging build.

Apple sign in works fine on staging. UI looks different in my case (because I am signed into Apple on my device?) but there is no overlap.

OSBotify · 2025-12-05T18:08:18Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.2.72-2 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

NJ-2020 added 2 commits November 11, 2025 13:49

chore: bump @invertase/react-native-apple-authentication to latest ve…

a8aae5f

…rsion

fix: apple login page overlaps device status bar

1edddef

melvin-bot bot assigned NJ-2020 Nov 11, 2025

NJ-2020 mentioned this pull request Nov 12, 2025

[Due for payment 2025-12-12] [HOLD on #74727] [$375] Android - Apple login page overlaps with device status bar #64116

Closed

8 tasks

NJ-2020 and others added 5 commits November 14, 2025 16:02

Merge branch 'Expensify:main' into fix/64116

84fa206

Merge branch 'Expensify:main' into fix/64116

85f1a05

fix: Podfile.lock

8f69423

fix: prettier error

5535895

Merge branch 'Expensify:main' into fix/64116

9ca8604

NJ-2020 marked this pull request as ready for review November 15, 2025 07:24

NJ-2020 requested review from a team as code owners November 15, 2025 07:24

melvin-bot bot requested review from joekaufmanexpensify and situchan November 15, 2025 07:24

melvin-bot bot requested review from a team and Julesssss and removed request for a team November 15, 2025 07:24

melvin-bot bot removed the request for review from a team November 15, 2025 07:24

situchan approved these changes Nov 15, 2025

View reviewed changes

Julesssss reviewed Nov 17, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

Merge branch 'Expensify:main' into fix/64116

e7226a2

NJ-2020 and others added 2 commits December 2, 2025 16:00

Merge branch 'Expensify:main' into fix/64116

cb9f6bd

fix podfile.lock

aa4ed32

NJ-2020 dismissed joekaufmanexpensify’s stale review via aa4ed32 December 2, 2025 09:08

revert unnecessary changes

f1e4eb3

Julesssss reviewed Dec 2, 2025

View reviewed changes

NJ-2020 added 2 commits December 3, 2025 09:13

Merge branch 'Expensify:main' into fix/64116

a0e966e

Merge branch 'Expensify:main' into fix/64116

35a661a

Julesssss added the InternalQA This pull request required internal QA label Dec 3, 2025

Julesssss approved these changes Dec 3, 2025

View reviewed changes

Julesssss merged commit 4d5f95c into Expensify:main Dec 3, 2025
39 checks passed

OSBotify mentioned this pull request Dec 4, 2025

Deploy Checklist: New Expensify 2025-12-04 #76726

Closed

60 tasks

fix: apple login page overlaps device status bar #74775

fix: apple login page overlaps device status bar #74775

Uh oh!

Conversation

NJ-2020 commented Nov 11, 2025 • edited by Julesssss Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

github-actions bot commented Nov 11, 2025

Uh oh!

codecov bot commented Nov 11, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Nov 15, 2025

Uh oh!

melvin-bot bot commented Nov 15, 2025

Uh oh!

NJ-2020 commented Nov 15, 2025

Uh oh!

situchan commented Nov 15, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

situchan commented Nov 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

situchan left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Nov 17, 2025

Uh oh!

Julesssss left a comment

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

NJ-2020 commented Nov 24, 2025

Uh oh!

NJ-2020 commented Nov 26, 2025

Uh oh!

github-actions bot commented Nov 26, 2025

Uh oh!

github-actions bot commented Nov 26, 2025

Uh oh!

NJ-2020 commented Dec 1, 2025

Uh oh!

Julesssss commented Dec 1, 2025

Uh oh!

NJ-2020 commented Dec 2, 2025

Uh oh!

github-actions bot commented Dec 2, 2025

Uh oh!

github-actions bot commented Dec 2, 2025

Uh oh!

Julesssss left a comment

Choose a reason for hiding this comment

Uh oh!

NJ-2020 commented Dec 3, 2025

Uh oh!

github-actions bot commented Dec 3, 2025

Uh oh!

github-actions bot commented Dec 3, 2025

Uh oh!

Julesssss commented Dec 3, 2025

Uh oh!

Uh oh!

OSBotify commented Dec 3, 2025

Uh oh!

NJ-2020 commented Dec 4, 2025

Uh oh!

OSBotify commented Dec 4, 2025

Uh oh!

Julesssss commented Dec 4, 2025

NJ-2020 commented Nov 11, 2025 •

edited by Julesssss

Loading

codecov bot commented Nov 11, 2025 •

edited by github-actions bot

Loading

situchan commented Nov 15, 2025 •

edited

Loading

situchan left a comment •

edited

Loading