Bump live-markdown to 0.1.302

[Skalakid]

Explanation of Change

This PR bumps the react-native-live-markdown version to the latest one (0.1.302), which includes:

• Codeblock markdown refactor
• Strikethrough markdown fix
• Input placeholder fix

It also updates Expensify markdown styles so new code blocks in the Live Markdown Inputs match the styles after sending the message.

Fixed Issues

$ #39518
$ #68518
$ #69048
PROPOSAL: https://swmansion.slack.com/archives/C01GTK53T8Q/p1756113217186459?thread_ts=1755900632.602309&cid=C01GTK53T8Q

Tests

Codeblocks refactor

1. Open any chat in E/App
2. Test pre and code markdowns in various scenarios, e.g.

test `inline code`
\```
code block
\```

(Remove backslashes)
3. Verify if the styles in the Live Markdown Input are the same as in a sent message
4. Verify if code blocks don't cause any UX issues while writing

Strikethrough not applied to blockquote text issue

1. Open any chat
2. Paste the text

~Test
> Test
Test~

3. Send the message
4. Note that the preview view and conversation view are consistent.

Placeholder issue

1. Verify if the placeholder is present in an empty Live Markdown like Composer in any chat room

• Verify that no errors appear in the JS console

Offline tests

Same as Tests

QA Steps

Same as Tests

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

android.chrome.mov

iOS: Native

ios.mov

iOS: mWeb Safari

ios.safari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

[github-actions]

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

[dannymcclain]

For the styling of code in the composer, can we just leave them how they currently are in staging/production? Do we need to change them for some reason? cc @dubielzyk-expensify

[dubielzyk-expensify]

Agree with Danny about keeping everything visually what it's like in prod today 👍

[Skalakid]

The whole point of Live Markdown Input is to preview how the message will look after sending while still typing. That's why we fixed this issue and introduced major refactor and many complex changes in the library to be able to do that and support the same styles in both pre and code markdowns.
Here is how it looks before and after my changes:

Current	Aligned

Are you sure we want to leave it as it is right now? In my opinion, it breaks the goal of the Live Markdown Input to replicate the sent message styles, and the current styling isn't that much visible for a user to determine if he is opening any code block while typing. So adding the same styles on the web to the inputs is much more beneficial, and it fixes this issue. What do you think @dannymcclain @dubielzyk-expensify?

[dubielzyk-expensify]

Ahhh, I see. I must've missed some context. I think showing the styling AND the syntax is a bit confusing, but if this is intended then that's fine. The way Slack does it is a lot neater to me where you remove the syntax once the styling is applied:

[melvin-bot]

@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[Skalakid]

That's how it was planned in a design doc and discussed with David Barrett a long time ago. Based on that, the Live Markdown library was created, and the syntaxes aren't removed when applying the markdown style

[Skalakid]

@dannymcclain @dubielzyk-expensify, how should we handle native devices? Right now, we can only make the styles the same as in the message on the web. The native devices look like that right now with the style changes:

Can we leave it as it is on the screen above, or should we turn off the new styling for native devices?

[dannymcclain]

I think showing the styling AND the syntax is a bit confusing, but if this is intended then that's fine.

This is pretty much how I feel. I think it's a little weird to show both syntax and styles, but I guess that's what we do for bold and italic and stuff so I guess it's not that big of a deal.

The styles in your Aligned image here do look pretty good, and I agree that it makes the code sections much more obvious.

As far as native goes—you're saying we can't mimic exactly what you're showing for the web Aligned image?

[Skalakid]

As far as native goes—you're saying we can't mimic exactly what you're showing for the web Aligned image?

@dannymcclain yes exactly. For now, code blocks have been updated only for the web. Native implementation still needs to be improved and tested

[dannymcclain]

Alright let's see what @dubielzyk-expensify thinks here. I think I'm good pushing the updated web version and then trying to follow up with native improvements, but I'd like to get his take.

[Skalakid]

Right now, with updated styles, it looks like that:

Web	Native

Is it okay? On native devices, we can't add any border radius, border color, or padding

[dannymcclain]

I'm good with that for now, but let's confirm with @dubielzyk-expensify to see if he has any strong feelings/opinions.

[ikevin127]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified tests pass on all platforms & I tested again on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android-hybrid.mp4

Android: mWeb Chrome

android-mweb.mp4

iOS: HybridApp

ios-hybrid.mp4

iOS: mWeb Safari

ios-mweb.mp4

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

[dubielzyk-expensify]

I'm fine with it as well I guess. Will we ever be able to make the styles match on native or is it a limitation for the forseable future?

[ikevin127]

🟢 LGTM

@Skalakid Can you please make sure to sync w/ main before merge ? Because I noticed you're outdated on this branch and the app crashes on iOS: Native because of unsupported.toSorted() usage in SidebarUtils.ts <- this was fixed on latest main.

Note

This PR was opened to address and follow-up on this deploy blocker issue in particular (currently fixed due to a version downgrade), which originated from the live-markdown PR that added the code block UI on web without testing it within the context of E/App.

This PR was opened in order to upgrade to the latest version of the library, not as a new feature to iterate on in terms of design, I think if we want to follow-up on that it should be in a new issue as to not hold-up this version upgrade for any longer.

[Skalakid]

I'm fine with it as well I guess. Will we ever be able to make the styles match on native or is it a limitation for the forseable future?

Yes, but it can take some time. We've prepared POC that works on both iOS and Android. We need to fix some edge cases and test in properly. Here are the PRs: Expensify/react-native-live-markdown#338, Expensify/react-native-live-markdown#306

[Skalakid]

@ikevin127 done

[ikevin127]

Thank you!
@mountiny All yours 🙌

[mountiny]

Thanks for the bump!

@dannymcclain @dubielzyk-expensify That is right - for the live markdown it was decided to show the syntax always similarly as Whatsapp does it

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by https://github.com/mountiny in version: 9.2.1-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.1-20 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅