Skip to content

Conversation

@ChALkeR
Copy link
Collaborator

@ChALkeR ChALkeR commented Jan 22, 2026

Passes on all test data in WPT
But that tests only single-codepoint encode, we need to test more, as iso-2022-jp maintains state
Also need to test failures

@ChALkeR ChALkeR force-pushed the chalker/encoder/iso-2022-jp branch 4 times, most recently from 1cc7717 to 2e19abb Compare January 22, 2026 22:27
@ChALkeR ChALkeR marked this pull request as ready for review January 22, 2026 22:35
@ChALkeR ChALkeR requested a review from Copilot January 22, 2026 22:35
@ChALkeR ChALkeR force-pushed the chalker/encoder/iso-2022-jp branch from 2e19abb to d11aa2f Compare January 22, 2026 22:39
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements the iso-2022-jp fatal encoder, completing support for all encoding formats in the Web Platform Tests. The encoder uses a state machine to manage transitions between ASCII, Roman, and JIS0208 character sets via escape sequences.

Changes:

  • Added iso-2022-jp encoder implementation with state machine logic for character set transitions
  • Removed iso-2022-jp exclusions from WPT test loader
  • Added preencoder formula for iso-2022-jp pointer-to-bytes conversion

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
tests/wpt/loader.cjs Removed iso-2022-jp special case exclusions from encoder tests, enabling validation of the new encoder implementation
fallback/multi-byte.js Added complete iso-2022-jp encoder with state machine (ASCII/Roman/jis0208 states), escape sequence management, halfwidth katakana mapping, and special character handling

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ChALkeR ChALkeR force-pushed the chalker/encoder/iso-2022-jp branch 2 times, most recently from 0a6149e to cde11eb Compare January 22, 2026 22:45
@ChALkeR ChALkeR requested a review from Copilot January 22, 2026 22:45
@ChALkeR ChALkeR force-pushed the chalker/encoder/iso-2022-jp branch 2 times, most recently from 52571f9 to c3e38cb Compare January 23, 2026 03:36
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@ChALkeR ChALkeR force-pushed the chalker/encoder/iso-2022-jp branch from c3e38cb to 5d085d7 Compare January 23, 2026 15:59
@ChALkeR
Copy link
Collaborator Author

ChALkeR commented Jan 23, 2026

This passes basic tests, landing
Will add more tests before the release

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ChALkeR ChALkeR merged commit 76ead9c into main Jan 23, 2026
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants