add dialog keys for the critical error handler

[microlith57]

:3

[DashingCat]

I agree that adding dialog keys is better than hard-coding text in UIs, and from my testing this PR works as intended, both in English and other languages (which fallback to English text).

However the changes in CriticalErrorHandler.cs could be simpler.
The function PopulateDialog is not needed as Dialog.Get already uses the English language if the dialog keys are not translated in other languages (relevant code below).

Everest/Celeste.Mod.mm/Patches/Dialog.cs

Lines 184 to 199 in 33ad712

	public static string Get(string name, Language language = null) {
	if (string.IsNullOrEmpty(name))
	return "";
	name = name.DialogKeyify();
	language ??= Dialog.Language;
	if (language.Dialog.TryGetValue(name, out string result))
	return result;
	if (language != FallbackLanguage && FallbackLanguage.Dialog.TryGetValue(name, out result))
	return result;
	WarnMissingDialogId(name, language);
	return "[" + name + "]";
	}

I will approve this PR once the changes in CriticalErrorHandler.cs are simplified.

[SnipUndercover]

Looks good, I just want to test before approving.

[SnipUndercover]

Suggested change

	playerShouldTeabag = CoreModule.Settings.CrashHandlerAlwaysTeabag || (!(Settings.Instance?.DisableFlashes ?? true) && new Random().Next(0, 10) == 0);
	isColonThree = CoreModule.Settings.CrashHandlerAlwaysColonThree || new Random().Next(0, 10) == 0;
	Random rng = new();
	playerShouldTeabag = CoreModule.Settings.CrashHandlerAlwaysTeabag || (!(Settings.Instance?.DisableFlashes ?? true) && rng.Next(0, 10) == 0);
	isColonThree = CoreModule.Settings.CrashHandlerAlwaysColonThree || rng.Next(0, 10) == 0;

[SnipUndercover]

Do we want to allow changing the exception message?

[SnipUndercover]

Probably add a comment that we're doing this to not have to call Dialog.Get multiple times in case something's wrong with the dialog.

[SnipUndercover]

Tested locally and it works well. Will approve once the remaining concerns are addressed. May your eyes be blessed with this beauty:

[SnipUndercover]

...i just realized i tested this but completely forgot to approve.

awesome

Though, one more review is necessary anyways so...

[Wartori54]

Looks good, I'd like Snip's comments to get resolved before approving though.
Also, I hate to say it but, the addition of the colon three "Easter Egg" feels a tad bit unnecessary, especially in the crash handler.