Set proper borderless windowed mode #988
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…an for Window Mode options
…og strings instead of just standard ToString call, which is still the default
Ran submodule update --remote
This reverts commit b20f2b3.
Revert "Ran submodule update --remote"
Contributor
Author
|
I have no idea why this failed |
maddie480
force-pushed
the
set-proper-borderless-windowed-mode
branch
from
ad10e89 to
7ccc66b
Compare
Contributor
Author
|
Cool |
Member
|
Due to a lack of activity, we decided to close this PR. Please reopen the PR or make a new one if this feature will be picked up again in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This PR is currently untested, mostly because I didn't know how to before but I'll notify once I do.
Something I noticed is that technically the game has a "windowed borderless" mode by setting the window size to 6, but the way the game is set up, this is a "fake borderless, and the window fitting the window properly isn't consistent, and it can also be moved with certain actions, leading it to become uncentered/offset.
This PR modifies the menu, adding an option between Fullscreen, Windowed, and the addition of Borderless, instead of having a boolean check for Fullscreen.
Internally it depends on SDL2 to handle the Borderless mode, in a similar way Celeste (or rather FNA) already uses SDL2 for fullscreen and windowed, so this should work with the same built-in engine.