Add option to lock file to current levelset (#588) #888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maddie480
added
the
review needed
maddie480
requested changes
Jun 7, 2025
Member
maddie480
left a comment
maddie480
left a comment
There was a problem hiding this comment.
Hm, I'm not sure players would understand what an option just called "Locked" does, especially since the level set selector isn't there for existing files 🤔 "Lock to current mod"?
Also, what happens if the file is "locked" in a mod that has been disabled? You would probably end up opening vanilla instead
maddie480-bot
added
changes requested
Contributor
Author
|
Thanks for the feedback, I'm fine with changing the wording, but I'm not quite sure how to handle disabled mods, so I'm marking the PR as draft for now. |
maddie480-bot
added
draft
Member
|
Due to a lack of activity, we decided to close this PR. Please reopen the PR or make a new one if this feature will be picked up again in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an option to lock an existing save file to its current levelset (preventing the user from switching levelset).
This option can be toggled from the
FileSelectSlotOUI, or using thelockcommand (like theassistorvariantscommands).The lock status is saved in the
CoreModuleSaveData.I'm wondering if adding a button can causes issues in TASes, if they don't expect it.
Closes #588.