Skip to content

Conversation

@ErynGalen
Copy link

This adds an Everest option to show the SID of unavailable maps in the FileSelect menu, instead of showing the vanilla progression.

@ErynGalen
Copy link
Author

Example:
2024-08-30_15:23:37

@maddie480 maddie480 added the discussion Needs input from others label Sep 18, 2024
@maddie480
Copy link
Member

The "discussion" the 6-month-old label refers to is "should this really be an option? or should it just be... implemented without a switch?" I don't remember if the discussion really happened

@maddie480
Copy link
Member

:despaireline: the discussion never happened

@maddie480 maddie480 added dormant and removed discussion Needs input from others labels Feb 14, 2025
@maddie480 maddie480 added review needed This PR needs 2 approvals to be merged (bot-managed) and removed dormant labels May 17, 2025
@microlith57
Copy link
Member

i feel like there is no reason we wouldn't want this behaviour, it's kinda just obviously correct. is there a reason anyone would want to have this option turned off?

Copy link
Contributor

@DashingCat DashingCat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @microlith57, I believe this does not need to be an option.

However, the current implementation conflicts with the mod CollabUtils2.

The IL manipulation in this PR removes the reference to the field Celeste.AreaData.Name, which is used here in modSelectSlotLevelSetDisplayName: https://github.com/EverestAPI/CelesteCollabUtils2/blob/cc0609b38505bd5a0442c3933367bd3400634576/LobbyHelper.cs#L679-L698

With the changes in the PR applied, the collab name is no longer used, and instead the last area of the collab is shown (for example, for the Strawberry Jam collab, the name shown on the file select slot is Grandmaster Lobby instead of Strawberry Jam Collab).

@SnipUndercover
Copy link
Member

With the changes in the PR applied, the collab name is no longer used, and instead the last area of the collab is shown (for example, for the Strawberry Jam collab, the name shown on the file select slot is Grandmaster Lobby instead of Strawberry Jam Collab).

@DashingCat Should we be worried about this? The collab will be unloaded anyway, making its collab name not present in the HashSet<string> collabNames.

return Dialog.Clean(AreaData.Areas[FurthestArea].Name);
}

float maxSize = 580;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does the value 580 come from?


[SettingSubText("MODOPTIONS_COREMODULE_TRUELASTAREAINFILESELECT_DESC")]
[SettingInGame(false)]
public bool TrueLastAreaInFileSelect { get; set; } = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As seen in the conversation in the comments, the new behavior seems more correct and there doesn't seem to be a reason to keep the old one around. The setting therefore is unnecessary.

@maddie480-bot maddie480-bot added changes requested This PR cannot be merged because changes were requested (bot-managed) and removed review needed This PR needs 2 approvals to be merged (bot-managed) labels Nov 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changes requested This PR cannot be merged because changes were requested (bot-managed)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants