-
Notifications
You must be signed in to change notification settings - Fork 97
Add option to show true LastArea in FileSelect #811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
|
The "discussion" the 6-month-old label refers to is "should this really be an option? or should it just be... implemented without a switch?" I don't remember if the discussion really happened |
|
:despaireline: the discussion never happened |
|
i feel like there is no reason we wouldn't want this behaviour, it's kinda just obviously correct. is there a reason anyone would want to have this option turned off? |
DashingCat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @microlith57, I believe this does not need to be an option.
However, the current implementation conflicts with the mod CollabUtils2.
The IL manipulation in this PR removes the reference to the field Celeste.AreaData.Name, which is used here in modSelectSlotLevelSetDisplayName: https://github.com/EverestAPI/CelesteCollabUtils2/blob/cc0609b38505bd5a0442c3933367bd3400634576/LobbyHelper.cs#L679-L698
With the changes in the PR applied, the collab name is no longer used, and instead the last area of the collab is shown (for example, for the Strawberry Jam collab, the name shown on the file select slot is Grandmaster Lobby instead of Strawberry Jam Collab).
@DashingCat Should we be worried about this? The collab will be unloaded anyway, making its collab name not present in the |
| return Dialog.Clean(AreaData.Areas[FurthestArea].Name); | ||
| } | ||
|
|
||
| float maxSize = 580; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where does the value 580 come from?
|
|
||
| [SettingSubText("MODOPTIONS_COREMODULE_TRUELASTAREAINFILESELECT_DESC")] | ||
| [SettingInGame(false)] | ||
| public bool TrueLastAreaInFileSelect { get; set; } = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As seen in the conversation in the comments, the new behavior seems more correct and there doesn't seem to be a reason to keep the old one around. The setting therefore is unnecessary.

This adds an Everest option to show the SID of unavailable maps in the FileSelect menu, instead of showing the vanilla progression.