make extensions case insensitive for type guessing and texture reloading #676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
aparently |
Kalobi
reviewed
Oct 16, 2023
| public static void Add(string path, ModAsset metadata) | ||
| => TryAdd(path, metadata); | ||
|
|
||
| private static readonly string[] METADATA_YAML_NAMES = { |
Member
There was a problem hiding this comment.
metadata.yaml and multimetadata.yaml are no longer supported, I just forgot to remove them from the type guesser apparently
maddie480
added
review needed
maddie480-bot
added
draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
do not merge until asset reloading is properly tested
currently, files such as
image.PNGare not recognised as PNG images, whereasimage.pngare.this PR makes the type guesser and texture reloader case insensitive for extensions, so those files would both be recognised as PNGs.