Skip to content

Implement map-specific postcard textures#1056

Merged
SnipUndercover merged 4 commits intoEverestAPI:devfrom
SnipUndercover:map-respritable-postcards
Jan 14, 2026
Merged

Implement map-specific postcard textures#1056
SnipUndercover merged 4 commits intoEverestAPI:devfrom
SnipUndercover:map-respritable-postcards

Conversation

@SnipUndercover
Copy link
Copy Markdown
Member

@SnipUndercover SnipUndercover commented Jan 2, 2026

Closes #1043. Allows mappers to specify the texture of the postcard in the map's .meta.yaml, like so:

# relative to the Gui atlas
PostcardTexture: "SnipUndercover/EverestDevelopment/postcard"

If the texture does not exist, the __fallback texture will be displayed. Because the fallback texture is so small, most of the text will be cut off by it.

I suppose a next PR could let mappers change the color of the savedata name text that's rendered on the postcard to allow dark postcards?

microlith57
microlith57 approved these changes Jan 2, 2026
View reviewed changes
Comment thread Celeste.Mod.mm/Patches/LevelEnter.cs
@maddie480-bot maddie480-bot added the 1: review needed This PR needs 2 approvals to be merged (bot-managed) label Jan 3, 2026
@SnipUndercover
Copy link
Copy Markdown
Member Author

SnipUndercover commented Jan 3, 2026

It seems that GH and Azure can't agree on the commit hash. I'll push an empty commit.

@SnipUndercover
Copy link
Copy Markdown
Member Author

SnipUndercover commented Jan 3, 2026

That jogged it just right, the TAS check is running.

@SnipUndercover SnipUndercover added the 4: should be squashed PR with a messy commit history that should be squash merged label Jan 3, 2026
Wartori54
Wartori54 approved these changes Jan 3, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@Wartori54 Wartori54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Together with allowing text color to be changed it would be nice to also add text repositioning in that upcoming PR for a more complete feature.

@SnipUndercover
Copy link
Copy Markdown
Member Author

SnipUndercover commented Jan 3, 2026

Will create an issue and assign myself to it to not forget.

@SnipUndercover SnipUndercover mentioned this pull request Jan 3, 2026
Open
@maddie480-bot
Copy link
Copy Markdown
Member

maddie480-bot commented Jan 3, 2026

The pull request was approved and entered the 3-day last-call window.
If no further reviews happen, it will end on Jan 6, 2026, 8:00 PM UTC, after which the pull request will be able to be merged.

@maddie480-bot maddie480-bot added 3: last call window This PR was approved, and is in the 5-day last-call window before getting merged (bot-managed) and removed 1: review needed This PR needs 2 approvals to be merged (bot-managed) labels Jan 3, 2026
@maddie480-bot
Copy link
Copy Markdown
Member

maddie480-bot commented Jan 6, 2026

The last-call window for this pull request ended. It can now be merged if no blockers were brought up.

@maddie480-bot maddie480-bot added 4: ready to merge This PR was approved and the last-call window is over (bot-managed) and removed 3: last call window This PR was approved, and is in the 5-day last-call window before getting merged (bot-managed) labels Jan 6, 2026
@SnipUndercover
Copy link
Copy Markdown
Member Author

SnipUndercover commented Jan 7, 2026

This will need a slight change in the .meta.yaml format to prepare for a future PR; do not merge yet.

@maddie480-bot
Copy link
Copy Markdown
Member

maddie480-bot commented Jan 8, 2026

The last-call window for this pull request ended. It can now be merged if no blockers were brought up.

@microlith57 microlith57 marked this pull request as draft January 9, 2026 09:22
@microlith57
Copy link
Copy Markdown
Member

microlith57 commented Jan 9, 2026

marked as draft at @SnipUndercover's request

@maddie480-bot maddie480-bot added 0: draft This PR is not ready for review yet (bot-managed) and removed 4: ready to merge This PR was approved and the last-call window is over (bot-managed) labels Jan 9, 2026
@SnipUndercover SnipUndercover marked this pull request as ready for review January 11, 2026 01:15
@SnipUndercover
Copy link
Copy Markdown
Member Author

SnipUndercover commented Jan 11, 2026

Moved PostcardTexture into a separate object in preparation for #1058, it's ready for review. It compiles and I don't think there'll be much to review.

@maddie480-bot
Copy link
Copy Markdown
Member

maddie480-bot commented Jan 11, 2026

The last-call window for this pull request ended. It can now be merged if no blockers were brought up.

@maddie480-bot maddie480-bot added 4: ready to merge This PR was approved and the last-call window is over (bot-managed) and removed 0: draft This PR is not ready for review yet (bot-managed) labels Jan 11, 2026
@maddie480-bot
Copy link
Copy Markdown
Member

maddie480-bot commented Jan 11, 2026

The pull request was approved and entered the 3-day last-call window.
If no further reviews happen, it will end on Jan 14, 2026, 2:16 AM UTC, after which the pull request will be able to be merged.

@maddie480-bot maddie480-bot added 3: last call window This PR was approved, and is in the 5-day last-call window before getting merged (bot-managed) and removed 4: ready to merge This PR was approved and the last-call window is over (bot-managed) labels Jan 11, 2026
@maddie480-bot
Copy link
Copy Markdown
Member

maddie480-bot commented Jan 14, 2026

The last-call window for this pull request ended. It can now be merged if no blockers were brought up.

@maddie480-bot maddie480-bot added 4: ready to merge This PR was approved and the last-call window is over (bot-managed) and removed 3: last call window This PR was approved, and is in the 5-day last-call window before getting merged (bot-managed) labels Jan 14, 2026
@SnipUndercover SnipUndercover merged commit 1922e54 into EverestAPI:dev Jan 14, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@microlith57 microlith57 microlith57 approved these changes

@Wartori54 Wartori54 Awaiting requested review from Wartori54

Assignees

No one assigned

Labels

4: ready to merge This PR was approved and the last-call window is over (bot-managed) 4: should be squashed PR with a messy commit history that should be squash merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Map-specific Postcard Textures

5 participants

@SnipUndercover @maddie480-bot @microlith57 @Wartori54 @maddie480