Skip to content

Conversation

@SilverDorian46
Copy link
Contributor

See issue #1044

Copy link
Member

@microlith57 microlith57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep it sure does do that!

improvement idea: add an interface ICameraTargetTrigger that mods can implement for the same functionality

@SilverDorian46
Copy link
Contributor Author

yep it sure does do that!

improvement idea: add an interface ICameraTargetTrigger that mods can implement for the same functionality

interface implemented

(I hope I've done this right)

@maddie480-bot maddie480-bot added the 1: review needed This PR needs 2 approvals to be merged (bot-managed) label Dec 25, 2025
@maddie480-bot maddie480-bot added 2: changes requested This PR cannot be merged because changes were requested (bot-managed) and removed 1: review needed This PR needs 2 approvals to be merged (bot-managed) labels Dec 25, 2025
Copy link
Member

@JaThePlayer JaThePlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@maddie480-bot
Copy link
Member

The pull request was approved and entered the 3-day last-call window.
If no further reviews happen, it will end on Dec 28, 2025, 2:18 PM UTC, after which the pull request will be able to be merged.

@maddie480-bot maddie480-bot added 3: last call window This PR was approved, and is in the 5-day last-call window before getting merged (bot-managed) and removed 2: changes requested This PR cannot be merged because changes were requested (bot-managed) labels Dec 25, 2025
@maddie480-bot
Copy link
Member

The last-call window for this pull request ended. It can now be merged if no blockers were brought up.

@maddie480-bot maddie480-bot added 4: ready to merge This PR was approved and the last-call window is over (bot-managed) and removed 3: last call window This PR was approved, and is in the 5-day last-call window before getting merged (bot-managed) labels Dec 28, 2025
@Wartori54 Wartori54 merged commit 8c55e10 into EverestAPI:dev Dec 28, 2025
3 checks passed
Wartori54 added a commit to Wartori54/Everest that referenced this pull request Dec 29, 2025
@Wartori54 Wartori54 mentioned this pull request Dec 29, 2025
Wartori54 added a commit that referenced this pull request Dec 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4: ready to merge This PR was approved and the last-call window is over (bot-managed)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants