GH-1228 Litegration by Rollczi · Pull Request #1228 · EternalCodeTeam/EternalCore

Rollczi · 2025-10-29T20:22:35Z

example:

class SomeTest extends IntegrationBaseTest {

    @LitegrationTest
    void test() {
         assertThat(Bukkit.getServer()).isNotNull();
    }

}

Rollczi · 2025-10-29T20:23:50Z

fajne czy nie fajne?

gemini-code-assist

Code Review

This pull request introduces Litegration for running integration tests on a Paper server, which is a great step towards improving code quality and reliability. The changes include setting up the build files, adding a base test class, and an initial integration test for the CatboyService.

My review includes suggestions to improve the build script configuration by removing redundancies and hardcoded versions, and to enhance the readability and maintainability of the new test code. I've also raised a high-severity concern about disabling parallel execution in Gradle, which could impact build performance.

gemini-code-assist · 2025-10-29T20:24:27Z

gradle.properties

 # https://docs.gradle.org/current/userguide/build_environment.html#sec:gradle_configuration_properties

-org.gradle.parallel=true
+org.gradle.parallel=false


Disabling parallel execution can significantly increase build times. While this might be a necessary workaround for the integration tests to function correctly, the reason for this change should be documented with a comment. This will help other developers understand the limitation and potentially re-enable it in the future if the underlying issue is resolved. The same applies to org.gradle.configuration-cache.parallel on line 6.

@Rollczi Can't we toggle this off per-task?

gemini-code-assist · 2025-10-29T20:24:27Z

eternalcore-plugin/build.gradle.kts

+repositories {
+    maven("https://repo.eternalcode.pl/releases/")
 }


This repositories block is redundant. The eternalcore-repositories convention plugin is applied on line 3, and it already includes the https://repo.eternalcode.pl/releases/ repository. You can safely remove this block to avoid duplication.

gemini-code-assist · 2025-10-29T20:24:28Z

eternalcore-plugin/build.gradle.kts


+tasks.testPaper {
+    eula = true
+    serverVersion = "1.21.7"


The server version 1.21.7 is hardcoded. To maintain consistency and ease of updates, it's better to define this version in your buildSrc/src/main/kotlin/Versions.kt file and reference it here.

For example, you could add const val PAPER_TEST_SERVER = "1.21.7" to Versions.kt and then use Versions.PAPER_TEST_SERVER here.

gemini-code-assist · 2025-10-29T20:24:28Z

eternalcore-plugin/build.gradle.kts

+
+    testPaperImplementation("dev.rollczi:litegration-client-mcprotocollib:${Versions.LITEGRATION}")
+
+    testPaperImplementation(platform("org.junit:junit-bom:6.0.0"))


The JUnit BOM version is hardcoded. You have a JUNIT_BOM constant defined in Versions.kt. Please use it here to ensure version consistency across the project.

testPaperImplementation(platform("org.junit:junit-bom:${Versions.JUNIT_BOM}"))

gemini-code-assist · 2025-10-29T20:24:28Z

eternalcore-plugin/build.gradle.kts

+    testPaperImplementation(platform("org.junit:junit-bom:6.0.0"))
+    testPaperImplementation("org.spigotmc:spigot-api:${Versions.SPIGOT_API}")
+
+    testPaperImplementation("org.assertj:assertj-core:3.27.6")


The AssertJ version 3.27.6 is hardcoded. It's a good practice to manage all dependency versions in the Versions.kt file. Please add a constant for this version there and use it here.

For example, you could add const val ASSERTJ_CORE = "3.27.6" to Versions.kt and then use Versions.ASSERTJ_CORE here.

I like the AssertJ framework, we should migrate other tests to it in near future.

gemini-code-assist · 2025-10-29T20:24:28Z

eternalcore-plugin/src/testPaper/java/com/eternalcode/core/IntegrationBaseTest.java

+        Player rollczi = Objects.requireNonNull(Bukkit.getPlayer(client.getName()));
+        scheduler.runTask(plugin, () -> {
+            action.accept(rollczi);
+            client.quit();
+        });


The variable rollczi is used to store the player object, but the player's name is passed as a parameter name. Using a generic name like player would make the code more readable and less confusing, as this method is intended to be a generic utility for joining any player. This change should also be reflected in the test that calls this method.

Suggested change

Player rollczi = Objects.requireNonNull(Bukkit.getPlayer(client.getName()));

scheduler.runTask(plugin, () -> {

action.accept(rollczi);

client.quit();

});

Player player = Objects.requireNonNull(Bukkit.getPlayer(client.getName()));

scheduler.runTask(plugin, () -> {

action.accept(player);

client.quit();

});

gemini-code-assist · 2025-10-29T20:24:28Z

...core-plugin/src/testPaper/java/com/eternalcode/core/catboy/CatboyServiceIntegrationTest.java

+        joinPlayer("Rollczi", rollczi -> {
+            catboyService.markAsCatboy(rollczi, Cat.Type.WHITE);
+            assertThat(catboyService.isCatboy(rollczi.getUniqueId())).isTrue();
+            assertThat(rollczi.getWalkSpeed()).isEqualTo(0.4F);


The walk speed value 0.4F is a magic number. It would be better to use a constant if one is defined in the production code (e.g., CatboyService.CATBOY_WALK_SPEED). This improves readability and maintainability. The same applies to the default walk speed 0.2F on line 31. If constants don't exist, consider adding them.

noyzys · 2025-10-30T09:53:08Z

fajne czy nie fajne?

Czy to jest zarys kompatybilnosci w stylu bridge cross-version?
na pierwszy rzut fajne ale tez fajnie gdyby samo w sobie mialo automatyczne auto-discovery, lepsze version parsing bo obecnie troche moze sie psuc przy niektorych buildach PAPERA no chyba ze wspieramy sortowane w stylu ,,najlepsze''

Rollczi · 2025-10-30T22:38:51Z

fajne czy nie fajne?

Czy to jest zarys kompatybilnosci w stylu bridge cross-version?

Tzn? To testy E2E/integracyjne (jak zwał tak zwał)

gdyby samo w sobie mialo automatyczne auto-discovery

Ale czego auto discovery?

lepsze version parsing bo obecnie troche moze sie psuc przy niektorych buildach PAPERA no chyba ze wspieramy sortowane
w stylu ,,najlepsze''

Chodzi o pobieranie jar servera? jakiś przykład

Jakubk15

Adjust to Gemini's suggestions

Jakubk15 · 2025-10-31T16:40:28Z

eternalcore-plugin/build.gradle.kts

+    testPaperImplementation(platform("org.junit:junit-bom:6.0.0"))
+    testPaperImplementation("org.spigotmc:spigot-api:${Versions.SPIGOT_API}")
+
+    testPaperImplementation("org.assertj:assertj-core:3.27.6")


I like the AssertJ framework, we should migrate other tests to it in near future.

Jakubk15 · 2025-10-31T16:41:04Z

gradle.properties

 # https://docs.gradle.org/current/userguide/build_environment.html#sec:gradle_configuration_properties

-org.gradle.parallel=true
+org.gradle.parallel=false


@Rollczi Can't we toggle this off per-task?

Jakubk15 · 2025-10-31T16:42:30Z

eternalcore-plugin/src/testPaper/java/com/eternalcode/core/IntegrationBaseTest.java

+
+
+    protected static void joinPlayer(String name, Consumer<Player> action) {
+        Litegration litegration = Litegration.getCurrent();


The getCurrent could be changed imo on Litegration's end, "current" in english without any context means just electricity

Jakubk15 · 2025-10-31T16:44:13Z

...core-plugin/src/testPaper/java/com/eternalcode/core/catboy/CatboyServiceIntegrationTest.java

+        EternalCoreApi api = EternalCoreApiProvider.provide();
+        CatboyService catboyService = api.getCatboyService();
+
+        joinPlayer("Rollczi", rollczi -> {


Suggested change

joinPlayer("Rollczi", rollczi -> {

joinPlayer("Rollczi", player -> {

No need to use player's name as parameter, as Rollczi is the only player anyway.

Jakubk15

Approving for now, but please adjust to my and Gemini's suggestions above @Rollczi

CitralFlo

Cool, check out review from Gemini

CitralFlo · 2025-11-02T18:58:54Z

gradle.properties

 org.gradle.caching=true
 org.gradle.configuration-cache=true
-org.gradle.configuration-cache.parallel=true
+org.gradle.configuration-cache.parallel=false


P1otrulla

Looks cool!

Litegration

ca909df

Rollczi requested a review from a team as a code owner October 29, 2025 20:22

Rollczi requested review from CitralFlo, Jakubk15, P1otrulla, noyzys and vLuckyyy October 29, 2025 20:23

gemini-code-assist bot reviewed Oct 29, 2025

View reviewed changes

Rollczi added the hacktoberfest-accepted label Oct 30, 2025

Rollczi changed the title ~~Litegration~~ GH-1228 Litegration Oct 30, 2025

Jakubk15 reviewed Oct 31, 2025

View reviewed changes

Jakubk15 approved these changes Nov 2, 2025

View reviewed changes

CitralFlo reviewed Nov 2, 2025

View reviewed changes

P1otrulla reviewed Nov 8, 2025

View reviewed changes

vLuckyyy removed request for noyzys and vLuckyyy December 9, 2025 12:11


		testPaperImplementation("dev.rollczi:litegration-client-mcprotocollib:${Versions.LITEGRATION}")

		testPaperImplementation(platform("org.junit:junit-bom:6.0.0"))



		protected static void joinPlayer(String name, Consumer<Player> action) {
		Litegration litegration = Litegration.getCurrent();

	joinPlayer("Rollczi", rollczi -> {
	joinPlayer("Rollczi", player -> {

Uh oh!

Conversation

Rollczi commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Rollczi commented Oct 29, 2025

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

Jakubk15 Oct 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

Jakubk15 Oct 31, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

noyzys commented Oct 30, 2025

Uh oh!

Rollczi commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Jakubk15 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Jakubk15 Oct 31, 2025

Choose a reason for hiding this comment

Uh oh!

Jakubk15 Oct 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Jakubk15 Oct 31, 2025

Choose a reason for hiding this comment

Uh oh!

Jakubk15 Oct 31, 2025

Choose a reason for hiding this comment

Uh oh!

Jakubk15 left a comment

Choose a reason for hiding this comment

Uh oh!

CitralFlo left a comment

Choose a reason for hiding this comment

Uh oh!

CitralFlo Nov 2, 2025

Choose a reason for hiding this comment

Uh oh!

P1otrulla left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

Rollczi commented Oct 29, 2025 •

edited

Loading

Jakubk15 Oct 31, 2025 •

edited

Loading

Rollczi commented Oct 30, 2025 •

edited

Loading

Jakubk15 left a comment •

edited

Loading

Jakubk15 Oct 31, 2025 •

edited

Loading