Fix /balance behavior for vanished players #6386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a vanish check for the automatic input corrector in getPlayer (fixed EssentialsX#6085). If the resolved target name (which may differ from argument[0] due to autocorrection) matches argument[0] case-insensitively, or the player is not vanished, the previous behavior is preserved. Otherwise, a fake player is created, resulting in the same “player not found” error as when the player is actually offline (with correct translation of message) -> fixed.
Simplified fix (EssentialsX#6386 (= Added a vanish check for the automatic input corrector in getPlayer (fixed EssentialsX#6085). If the resolved target name (which may differ from argument[0] due to autocorrection) matches argument[0] case-insensitively, or the player is not vanished, the previous behavior is preserved. Otherwise, a fake player is created, resulting in the same “player not found” error as when the player is actually offline (with correct translation of message) -> fixed.)) by adjusting getHidden to false -> fixed and simplified.
Changed getHidden to true for console as it should be able to shortcut even vanished accounts.
Fixed vanish bug (if vanished, then handle as offlineUser).
Contributor
Author
|
Also updated Commandignore as it included the same issue |
Added implementation for vanish.see and vanish.interact to allow short form usage.
Bugfix: If a player without permission uses /bal [player], their own balance is no longer shown. Instead, a permission error is sent to the player and logged in the console in the correct language -> fixed.
Contributor
Author
|
Fixed a few other bugs I discovered while reading code |
Contributor
Author
|
I would be very happy if changes could be approved, thanks! @JRoy :-) |
JRoy
changed the title
JRoy
approved these changes
Jan 3, 2026
Member
JRoy
left a comment
JRoy
left a comment
There was a problem hiding this comment.
thanks for the pr, i changed your fix slightly/made some related changes to ignore.
Euphillya
added a commit
to Euphillya/Essentials-Folia
that referenced
this pull request
Jan 4, 2026
EssentialsX@000e6c5 Mirror dumps on gist (EssentialsX#6193) EssentialsX@b349517 Fix Spigot 1.21.10+ ReflServerStateProvider (EssentialsX#6377) EssentialsX@ac66618 Fix error when running /helpop from console (EssentialsX#6385) EssentialsX@68c304e Fix /balance behavior for vanished players (EssentialsX#6386) EssentialsX@9ad754b Use Discord name instead of tag for /msg sender (EssentialsX#6383)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6085