Skip to content

feat: add agentv-plugin-review skill#772

Open
christso wants to merge 5 commits intomainfrom
feat/agentv-plugin-review
Open

feat: add agentv-plugin-review skill#772
christso wants to merge 5 commits intomainfrom
feat/agentv-plugin-review

Conversation

@christso
Copy link
Collaborator

@christso christso commented Mar 25, 2026

Summary

  • Add agentv-plugin-review skill to the agentv-dev plugin for reviewing AI plugin PRs
  • Reviews across three dimensions: skill quality, eval correctness, and workflow architecture
  • Includes reference checklists based on OpenSpec, Superpowers, and Compound Engineering patterns
  • 8-test eval covering the key review scenarios

Files

Skill:

  • plugins/agentv-dev/skills/agentv-plugin-review/SKILL.md — 5-step review process
  • plugins/agentv-dev/skills/agentv-plugin-review/references/eval-checklist.md — Eval file review checklist
  • plugins/agentv-dev/skills/agentv-plugin-review/references/workflow-checklist.md — Workflow architecture checklist

Eval:

  • evals/agentv-plugin-review/agentv-plugin-review.eval.yaml — 8 test cases

Test plan

  • All 8 eval test cases pass in agent mode (subagent execution + rubric grading)
  • Pre-commit hooks pass (build, typecheck, lint, test, eval validation)

🤖 Generated with Claude Code

Add a new skill to agentv-dev for reviewing AI plugin PRs across three
dimensions: skill quality, eval correctness, and workflow architecture.

Includes:
- SKILL.md with 5-step review process
- references/eval-checklist.md for eval file review
- references/workflow-checklist.md for OpenSpec-based workflow review
- 8-test eval covering missing evals, naming, assertions, file paths,
  repeated inputs, hard gates, factual contradictions, and command refs

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Mar 25, 2026

Deploying agentv with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0c8737f
Status: ✅  Deploy successful!
Preview URL: https://6ae37100.agentv.pages.dev
Branch Preview URL: https://feat-agentv-plugin-review.agentv.pages.dev

View logs

christso and others added 4 commits March 25, 2026 23:35
Rewrite eval to use pi-cli target with a mock workspace containing a
deploy-auto plugin with planted issues: missing eval, wrong extensions,
no assertions, relative paths, repeated inputs, missing hard gates,
factual contradiction, nonexistent command reference, and hardcoded paths.

Uses shorthand input, skill-trigger assertions, and workspace template
instead of loading SKILL.md directly.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The pi-coding-agent provider is configured as the 'default' target
in .agentv/targets.yaml. pi-cli is not a valid target name.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Add pi-cli as a named target in .agentv/targets.yaml using the
pi-coding-agent provider. Update the plugin-review eval to use it.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Add references/skill-quality-checklist.md covering CSO (Claude Search
Optimization), description anti-patterns, content quality, file org,
flowchart usage, and discipline-enforcing skill checks.

Update SKILL.md Step 2 to reference the checklist and integrate key
CSO principles (description must not summarize workflow, etc).

Remove plugin.json from review table (handled by CI).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant