fix(dashboard): settle remote sync button state#1343
Merged
Conversation
Deploying agentv with
|
| Latest commit: |
825e3fa
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3752a154.agentv.pages.dev |
| Branch Preview URL: | https://fix-dashboard-remote-sync-st.agentv.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Dashboard remote sync toolbar now settles back to the current remote status after syncs overlap. Before this fix, a project could clear its pending remote metadata while the button stayed disabled as
Syncing...until reload; now the sync response updates the remote-status cache and status refetches can move the toolbar back toClean/Sync Projectwithout a page reload.Remote status polling now runs only while the server reports
sync_status=syncing, so a blocked concurrent sync response does not leave the UI stranded on stale in-progress state.Verification
(cd apps/dashboard && bun test src/lib/project-sync-status.test.ts)— 12 passbun --filter @agentv/dashboard test— 83 passbun --filter @agentv/dashboard build— pass; rebuilt Dashboard dist before browser UATbun run lint— passbun --filter @agentv/core typecheck && bun --filter @agentv/phoenix-adapter typecheck && bun --filter agentv typecheckandbiome check .— passRed/Green UAT Evidence
av-fisshoweddashboard-project-after-sync-settled.pngstuck onSyncing...despite/api/projects/av-fis-dashboard/remote/statusreturningsync_status=clean,dirty_paths=[].Sync Metadata; after clicking it, the UI settled toClean/Sync Projectwithout reload and/api/projects/project/remote/statusreturnedsync_status=clean,dirty_paths=[]./tmp/age7-final-green-clean.png.Post-Deploy Monitoring & Validation
Syncing...,sync_status=syncing,remote/sync,remote/status,Results repo sync is already in progress.Cleanand the sync button is enabled withSync Projectwithout reload.remote/statusiscleanbut the toolbar button remains disabled asSyncing...for more than one poll interval./remote/statusand revert this PR if polling/cache hydration causes unexpected Dashboard load.