Extend EVE plugin to handle popEVE data#814
Merged
nakib103 merged 9 commits intoEnsembl:mainfrom Jan 19, 2026
Merged
Conversation
nakib103
requested changes
Dec 3, 2025
| my $class_key = "Class" . $self->{class_number}; | ||
|
|
||
| # prefer INFO descriptions pulled from VCF but fall back to hard-coded descriptions | ||
| my $h = { |
Contributor
There was a problem hiding this comment.
if only popEVE file is given they will be still be in the header.
Contributor
Author
There was a problem hiding this comment.
I have now hard-coded them and added logic so that only the relevant descriptions (pop, eve or both) end up in the output file.
| alts => [$variant->{alt}], | ||
| pos => $variant->{start}, | ||
| } | ||
| { ref => $ref_allele, alts => $alt_alleles, pos => $vf->{start}, strand => $vf->strand }, |
Contributor
There was a problem hiding this comment.
it would be better to keep the formatting same as before, as other plugins use the same format.
Contributor
Author
There was a problem hiding this comment.
I have reverted the styling.
nakib103
requested changes
Dec 3, 2025
Contributor
nakib103
left a comment
There was a problem hiding this comment.
Besides the other comments, it is also better to add -
- an example command for popEVE in the synopsis.
- instead of using Bio::DB::HTS can we hardcode the header? in some cases the user might not have installed the library and it would restrict them to use the plugin.
Contributor
Author
Done.
Done. |
nakib103
requested changes
Jan 14, 2026
Contributor
nakib103
left a comment
There was a problem hiding this comment.
Looks good @ainefairbrother
couple of checks to be added
Co-authored-by: Syed Nakib Hossain <snhossain@ebi.ac.uk>
Co-authored-by: Syed Nakib Hossain <snhossain@ebi.ac.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR extends the VEP plugin
EVE.pmto be able to handle popEVE data. As such, the plugin can now annotate using EVE data OR popEVE data OR both.Main changes
popeve_filefileparameter as is - this param is still for the EVE filepopEVE_*fields when a popEVE record matches the user's input, and continues to emitEVE_*fields when an EVE record matchesget_matched_variant_allelesTesting
EVE.pmfor EVE/popEVE input file download and prep instructions, however, the EVE file is available on nfs atensembl/variation/data/EVEin.vcf:VEP command:
Output:
EVE_columns and 9popEVE_columns