WorldEdit-Folia#2462
WorldEdit-Folia#2462Yomamaeatstoes wants to merge 22 commits intoEngineHub:masterfrom Folia-Inquisitors:master
Conversation
Initial Folia support. ( b7abc4a )
octylFractal
left a comment
octylFractal
left a comment
There was a problem hiding this comment.
This is almost certainly not enough fixes, as entities will likely need adjusting to Folia as well.
See #2379 for some more changes that may be needed, but likely more vetting will be needed before we declare full Folia support.
| # Folia Inquisitors | ||
| [<img src="https://github.com/Folia-Inquisitors.png" width=80 alt="Folia-Inquisitors">](https://github.com/orgs/Folia-Inquisitors/repositories) | ||
| [<img src="https://github.com/TechnicallyCoded.png" width=80 alt="TechnicallyCoded">](https://github.com/TechnicallyCoded) | ||
| [<img src="https://github.com/Yomamaeatstoes.png" width=80 alt="Yomamaeatstoes">](https://github.com/Yomamaeatstoes) |
There was a problem hiding this comment.
Why was this added? I don't see why we should be specifically calling these groups/people out. Unless you plan to assist in maintaining Folia support, in which case it would be good to mention that here, e.g. "Thanks to <xyz> for maintaining Folia support in WorldEdit". But if you do so, we will assign Folia issues to you.
There was a problem hiding this comment.
Thanks for the feedback. I have talked to one of the members in the organization who so far plans on doing a pull request. Once that is done it should be reflected in the readme.
| Block bukkitBlock = getWorld().getBlockAt(position.getBlockX(), position.getBlockY(), position.getBlockZ()); | ||
| bukkitBlock.setBlockData(BukkitAdapter.adapt(block), sideEffects.doesApplyAny()); | ||
| return true; |
There was a problem hiding this comment.
This completely breaks setting NBT and side-effect support in all Bukkit-based servers. The solution here must not remove the calls to worldNativeAccess.
There was a problem hiding this comment.
Thanks for the feedback.
There was a problem hiding this comment.
I already have a proposed idea.
3 participants
Hello, I have been using for the past month. I have tested it and it seems others have as well.
If you have any requested changes let me know.