client manager: added user context to error handler (#424)#425
Open
gabbla wants to merge 2 commits intoEmbeddedRPC:developfrom
Open
client manager: added user context to error handler (#424)#425gabbla wants to merge 2 commits intoEmbeddedRPC:developfrom
gabbla wants to merge 2 commits intoEmbeddedRPC:developfrom
Conversation
amgross
suggested changes
May 5, 2025
Contributor
amgross
left a comment
There was a problem hiding this comment.
Adding context when it is not critical is probably not best practice and this change is API breaking.
I would suggest if you need just to create separate handler for each client and they all can call single function with context they will provide.
Also if want to go with this approach probably need to modify also erpc_client_set_error_handler and erpc_arbitrated_client_set_error_handler
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request
Choose Correct
Describe the pull request
This pull request addresses and propose a possible implementation regarding the feature request presented in #424
To Reproduce
When registering an error handler, the user can supply its own context (or
nullptr).Steps you didn't forgot to do
Additional context