Add consistent Restart button to watcher overview

[Joxx0r]

Summary

• The Service and Zoekt rows in the dashboard overview always show a Restart button when running, but the Watcher row had no action button when active — only a Start button when down
• Adds a Restart button (action-btn-warn) to the watcher overview row, matching the existing pattern for Service and Zoekt
• Consolidates the version-mismatch alert to use the same overviewRestartWatcher function, removing the old stopAndRestartWatcher

Test plan

• Open the dashboard with a running watcher — verify a yellow "Restart" button appears in the watcher overview row
• Click Restart — verify it stops and restarts the watcher, then refreshes the overview
• Trigger a version mismatch (different git hashes) — verify the alert's Restart Watcher button also works
• With watcher stopped, verify the "Start" button still appears as before

🤖 Generated with Claude Code

[claude]

Review: PR #61 — Add consistent Restart button to watcher overview

The motivation is solid — consistency between Service, Zoekt, and Watcher rows is a clear UX improvement. The consolidation of stopAndRestartWatcher into overviewRestartWatcher is the right direction. However, there are two bugs that need fixing before merge.

---

Bug 1 — Orphaned #version-alert-status span (dead HTML + dead CSS)

The version-alert template still injects the status span, but overviewRestartWatcher never writes to it:

// public/index.html ~line 444 (updated branch)
actionsEl.innerHTML = `
  <button class="btn-primary" onclick="overviewRestartWatcher(this)">Restart Watcher</button>
  <span class="version-alert-status" id="version-alert-status"></span>`;  // ← never populated

And the CSS at line 40 (.version-alert-status) is also now unused.

The old stopAndRestartWatcher used this span to show progress ("Waiting for watcher to stop...", etc.). Now that status is encoded in the button text, the span should be removed from the template. The CSS rule can be removed too if nothing else references it.

---

Bug 2 — Button label resets to wrong text for the version-alert case

overviewRestartWatcher always resets to 'Restart' on error/timeout:

setTimeout(() => { btn.textContent = 'Restart'; btn.disabled = false; }, 5000);

But the version-mismatch alert button is labelled 'Restart Watcher'. After any failure, that button will permanently read 'Restart' instead of 'Restart Watcher'.

One fix: capture the original label before mutating it:

async function overviewRestartWatcher(btn) {
  const originalText = btn.textContent;
  btn.disabled = true;
  btn.textContent = 'Restarting...';
  // ...
  // In error/timeout paths:
  setTimeout(() => { btn.textContent = originalText; btn.disabled = false; }, 5000);
}

---

Minor — /api/watcher/stop response not checked

The stop call's response is never checked for non-2xx status. If the stop endpoint errors, the code falls through to waitForWatcherState(false) and silently times out instead of surfacing the error. This was also present in the old stopAndRestartWatcher, so not a regression, but worth fixing while touching this code.

---

Test coverage

The test plan is manual-only. No new automated tests — acceptable for a UI-only change in this codebase's current state, but the error/timeout paths in particular are easy to miss manually. Consider adding at least one test for the error branch if there's an existing JS test harness.

---

Summary: Two confirmed bugs (orphaned span, label reset). Please fix before merging.