Fix general search bar not restricting to current space#1315
Open
fbacall wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the general /search (SearchController#index) to scope “general search bar” Solr queries to the current space when the spaces feature is enabled, preventing cross-space results from appearing unintentionally.
Changes:
- Apply the existing
Facets.across_all_spacesSolr constraint (defaulting to “current space only”) within general search queries. - Gate the constraint behind
Facets.applicable?so it only affects models that are space-associated when spaces are enabled.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+16
to
+18
| if Facets.applicable?(:across_all_spaces, model) | ||
| Facets.across_all_spaces(self, false, current_user) | ||
| end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Motivation and context
It was returning results from all spaces.
Checklist