use const-correct types with strchr, strstr, etc.#8932
Open
whitslack wants to merge 1 commit intoElementsProject:masterfrom
Open
use const-correct types with strchr, strstr, etc.#8932whitslack wants to merge 1 commit intoElementsProject:masterfrom
strchr, strstr, etc.#8932whitslack wants to merge 1 commit intoElementsProject:masterfrom
Conversation
Because ccan/config.h #defines _GNU_SOURCE, glibc declares qualifier- preserving generic prototypes for the twelve "qualifier-losing search functions" (bsearch, bsearch_s, memchr, strchr, strpbrk, strrchr, strstr, wcschr, wcspbrk, wcsrchr, wcsstr, wmemchr), even in -std=gnu11 mode. Several places throughout the code base were calling these search functions and inadvertently stripping away the constness of their return values, triggering compilation errors due to -Werror. Fix up these call sites so that the assignments of their return values do not implicitly discard the const qualifier. Changelog-None
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
ccan/config.h#defines_GNU_SOURCE, glibc declares qualifier-preserving generic prototypes for the twelve “qualifier-losing search functions” (bsearch,bsearch_s,memchr,strchr,strpbrk,strrchr,strstr,wcschr,wcspbrk,wcsrchr,wcsstr,wmemchr), even in-std=gnu11mode.Several places throughout the code base were calling these search functions and inadvertently stripping away the constness of their return values, triggering compilation errors due to
-Werror. Fix up these call sites so that the assignments of their return values do not implicitly discard theconstqualifier.Changelog-None
Checklist
Before submitting the PR, ensure the following tasks are completed. If an item is not applicable to your PR, please mark it as checked:
tools/lightning-downgrade(N/A)