CI: stop rebuilding everything in every step!#8678
Open
rustyrussell wants to merge 14 commits intoElementsProject:masterfrom
Open
CI: stop rebuilding everything in every step!#8678rustyrussell wants to merge 14 commits intoElementsProject:masterfrom
rustyrussell wants to merge 14 commits intoElementsProject:masterfrom
Conversation
madelinevibes
added
the
Status::Ready for Review
Collaborator
|
Will the |
rustyrussell
force-pushed
the
guilt/ci-no-rebuild
branch
from
2f227b7 to
b431b4f
Compare
rustyrussell
force-pushed
the
guilt/ci-no-rebuild
branch
from
b431b4f to
089b759
Compare
Contributor
Author
Indeed. I'll make the tests depend on this, so it will abort. |
rustyrussell
force-pushed
the
guilt/ci-no-rebuild
branch
3 times, most recently
from
190cc1a to
eceb7cc
Compare
More future proof, better for self-hosted runners. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
guilt/ci-no-rebuild
branch
from
eceb7cc to
8faf738
Compare
rustyrussell
force-pushed
the
guilt/ci-no-rebuild
branch
2 times, most recently
from
e427d7c to
db91469
Compare
check-source-bolt needs devtools, and check-python needs a full build. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
It's done by setup.sh, so simply set the env var for that. Don't try to reinstall valgrind or call `sudo apt-get update -qq` either, since setup.sh does that too. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Our CI didn't run the Tor tests, and when we do, they fail (particularly tests/test_gossip.py::test_tor_port_onions and test_static_tor_onions): ``` lightningd-2 2026-02-16T01:06:28.607Z INFO connectd: dev_report_fds: 3 -> hsm fd lightningd-2 2026-02-16T01:06:28.607Z INFO connectd: dev_report_fds: 4 -> gossipd fd lightningd-2 2026-02-16T01:06:28.607Z INFO connectd: dev_report_fds: 5 -> listener (connection_in) lightningd-2 2026-02-16T01:06:28.607Z INFO connectd: dev_report_fds: 5 name IPv4 socket 127.0.0.1:46045 lightningd-2 2026-02-16T01:06:28.607Z **BROKEN** connectd: dev_report_fds: 6 open but unowned? fd mode: socket ``` Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
No point spending 1m24 seconds for *each* different compiler variant. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Using RUST_TARGET=release is slower than RUST_TARGET=debug, *but* the images are much bigger: RUST_TARGET=release: 8m53s 130MB RUST_TARGET=debug: ??? 339MB So create our own profile which gives the best of both worlds. RUST_TARGET=small: ??? 132MB Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Make cdump-enumstr use libccan.a, rather than explicit ccan object: it's the last one. And mark submodcheck phony, as it is. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This means we don't have to include them in our bundle. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This keeps it simpler for future expansion, and also means we won't rebuild them as much. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Here are the speeds and sizes of different compressors: gzip -1: 0m20.914s 789012066 gzip -2: 0m23.846s 775576167 gzip -3: 0m26.088s 765520181 gzip -4: 0m28.264s 748485795 gzip -5: 0m35.916s 736567221 gzip -6: 0m49.906s 730337022 gzip -7: 1m2.391s 728726884 bzip2: 1m32.191s 711695852 gzip -8: 1m51.655s 727303811 gzip -9: 2m51.123s 726946796 Uncompressing time: bzip2: 0m43.353s gzip -5: 0m8.318s The downside is that this is only useful on a *freshly built* tree: it will include everything config.vars and newer. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
…builds. For CI we want to make sure we don't rebuild. CC=false doesn't work because we reply on the output of "$CC -dumpmachine" for the external build directory. So we would use: make CC=devtools/cc-nobuild CARGO=false Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
guilt/ci-no-rebuild
branch
2 times, most recently
from
b67eba7 to
ee8481e
Compare
We use the same fragment everywhere for consistency, even though some stages don't actually call make. The magic is: CARGO=false CC=devtools/cc-nobuild SUPPRESS_GENERATION=1 Which causes us to fail if we want to rebuild. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
…rce step. As pointed out by Alex Myers: we don't want to waste time running the complex steps if the generated files are not up-to-date. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
guilt/ci-no-rebuild
branch
from
ee8481e to
4b91077
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our build steps are not working, in the sense we are rebuilding every time.
Changelog-None: CI only.