fix: Check if web entry already on Procfile.dev before appending it#542
Open
Andy9822 wants to merge 1 commit intoElMassimo:mainfrom
Open
fix: Check if web entry already on Procfile.dev before appending it#542Andy9822 wants to merge 1 commit intoElMassimo:mainfrom
web entry already on Procfile.dev before appending it#542Andy9822 wants to merge 1 commit intoElMassimo:mainfrom
Conversation
Andy9822
force-pushed
the
check-web-entry-on-procfile-before-appending-to-file
branch
from
d70e471 to
c8884d6
Compare
Andy9822
changed the title
web entry already on Profile before appending itweb entry already on Procfile.dev before appending it
Author
|
hey @ElMassimo , is this something you'd be okay in adding to |
Owner
|
Hi Andy! I think it's a nice improvement, I'll test it when I have some time. |
|
I just ran into this as well and would love to see this PR get merged 😄 |
Author
|
hey @ElMassimo 👋, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📖
This pull request adds a logic to check wether the
Procfile.devalready has awebentry. In case it does, we don't append a duplicatewebentry.Background 📜
This was happening because the CLI code would append the entry without checking the file content.
However, on Rails apps generated with the Rails generator, the
webentry would already be in the Procfile. This would cause 2webentries on the same fileThe Fix 🔨
By changing the
appendmethod to beappend_if_no_web_entrywe can safely perform the action since we are now checking the file content.Screenshots 📷
Fixes #541