Use Rolldown native MagicString for faster sourcemap generation#345
Open
Use Rolldown native MagicString for faster sourcemap generation#345
Conversation
Replace the JS `magic-string` dependency with Rolldown's native `RolldownMagicString` in all transform handlers. Native magic string performs string mutations and sourcemap generation in Rust, avoiding the overhead of JS-based sourcemap encoding. Transform hooks now return the `RolldownMagicString` instance directly as `code`, letting Rolldown handle sourcemap generation internally without serialization. https://claude.ai/code/session_01Gk9SG3CqsszLBotJRTf45S
|
View your CI Pipeline Execution ↗ for commit 9de2ba1
☁️ Nx Cloud last updated this comment at |
Deploying iles with
|
| Latest commit: |
9de2ba1
|
| Status: | 🚫 Build failed. |
…ances Reuse the lazily-created RolldownMagicString that Rolldown provides via the transform hook's meta parameter, avoiding redundant instance creation. The wrapLayout and wrapIslandsInSFC helpers now receive the magic string from their callers instead of constructing their own. https://claude.ai/code/session_01Gk9SG3CqsszLBotJRTf45S
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the JS
magic-stringdependency with Rolldown's nativeRolldownMagicStringin all transform handlers. Native magic stringperforms string mutations and sourcemap generation in Rust, avoiding
the overhead of JS-based sourcemap encoding. Transform hooks now
return the
RolldownMagicStringinstance directly ascode, lettingRolldown handle sourcemap generation internally without serialization.
https://claude.ai/code/session_01Gk9SG3CqsszLBotJRTf45S