Open
Conversation
This fixes Eisa01#182. The config option `periodic_save_min_offset` controls this feature. If the offset is 5, then the video position is only saved if it differs by more than 5 seconds from the previous saved video position. This keeps the log file from being constantly filled, particularly when the video is paused. If 0, the feature is turned off. It's necessary to not call `read_log_table()` when restoring history position, because the current history log has been updated, but we really want to load from the history log that was read into memory during initialization. This conflicts with features that modify the history during playback, but I don't use those features so I can't porperly test them. Instead, `read_log_table()` is now called only if the new periodic position logging is turned off.
Author
|
@Eisa01 What does this break, if anything? They key change is that the history file is not reloaded during resume if periodic saving is active. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #182.
The config option
periodic_save_min_offsetcontrols this feature. If the offset is 5, then the video position is only saved if it differs by more than 5 seconds from the previous saved video position. This keeps the log file from being constantly filled, particularly when the video is paused. If 0, the feature is turned off.It's necessary to not call
read_log_table()when restoring history position, because the current history log has been updated, but we really want to load from the history log that was read into memory during initialization. This conflicts with features that modify the history during playback, but I don't use those features so I can't porperly test them. Instead,read_log_table()is now called only if the new periodic position logging is turned off (and it is off by default).