Conversation
Eisa01
left a comment
Eisa01
left a comment
There was a problem hiding this comment.
Looks good, just slight feedback needed on some of the changes.
| function get_file() | ||
| local path = mp.get_property('path') | ||
| if not path then return end | ||
| -- ignoring protocols that do not support playback recovery |
There was a problem hiding this comment.
Is this only to ignore these protocols from saving to history?
Or these protocols cause a problem if it was added to history?
There was a problem hiding this comment.
Due to the limitations of mpv these protocols can't resume playback from a record, and there's little benefit to saving these invalid entries other than polluting the history list.
Ref: https://mpv.io/manual/master/#protocols
| if string.match(c, '(.*)'..c_pre_attribute) then | ||
| c_clip_file = string.match(c_protocols, '(.*)'..c_pre_attribute) | ||
| c_clip_time = tonumber(string.match(c_protocols, c_pre_attribute..'(%d*%.?%d*)')) | ||
| elseif string.match(c, '^\"(.*)\"$') then |
There was a problem hiding this comment.
Any reason for the removal of this condition?
There was a problem hiding this comment.
Now this has been processed in the make_raw function, no additional processing is required.
| if string.match(c, '(.*)'..c_pre_attribute) then | ||
| c_clip_file = string.match(c, '(.*)'..c_pre_attribute) | ||
| c_clip_time = tonumber(string.match(c, c_pre_attribute..'(%d*%.?%d*)')) | ||
| elseif string.match(c, '^\"(.*)\"$') then |
There was a problem hiding this comment.
Any reason for the removal of this condition?
|
There seems to be a bug with github and my reply turned into self-censorship... |
|
Any progress? |
|
Can I have the clarifications in the review section for the questions I asked? |
Of course. |
Are there still some github bugs ? because I couldn't see your feedback on Eisa01's review.. |
3 participants
No description provided.