Jon/fix/search keyboard dismiss #5899
Merged
+43
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swansontec
approved these changes
Jan 15, 2026
Comment on lines
57
to
64
| const handleCancel = useHandler(() => { | ||
| onCancel() | ||
| }) | ||
|
|
||
| const handleSearchFocus = useHandler(() => { | ||
| onStartSearching() | ||
| onFocus() | ||
| }) |
Contributor
There was a problem hiding this comment.
Optional: Get rid of handleCancel, and just pass onCancel straight to the text input. Same for handleSearchFocus. Straight pass-through like this is allowed and even encouraged - one less function to create & run.
Jon-edge
force-pushed
the
jon/fix/search-keyboard-dismiss
branch
2 times, most recently
from
384bc88 to
2e7a980
Compare
- Fix misleading reinvented prop names - Remove styled components
- Dismiss keyboard when search is submitted - Disable auto-correct for search input
Jon-edge
force-pushed
the
jon/fix/search-keyboard-dismiss
branch
from
2e7a980 to
93ec43c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have:
https://app.asana.com/1/9976422036640/project/1200382638405084/task/1212576624322582?focus=true
Note
Improves search UX and aligns API usage across scenes.
SearchFooter: replaceonStartSearching/onDoneSearchingwithonFocus/onCancel, addonSubmitEditingtodismissthe keyboard, and setautoCorrect={false}; removesSpacewrapper and simplifies handlersCoinRankingScene,GiftCardMarketScene,Staking/EarnScene,TransactionListScene, andWalletDetailsScene(plusWalletListScene) to new propsWritten by Cursor Bugbot for commit 93ec43c. This will update automatically on new commits. Configure here.