feat: typescript testing, correcting typescript errors#542
Merged
Justintime50 merged 5 commits intomasterfrom Feb 20, 2026
Merged
feat: typescript testing, correcting typescript errors#542Justintime50 merged 5 commits intomasterfrom
Justintime50 merged 5 commits intomasterfrom
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Justintime50
commented
Feb 19, 2026
|
|
||
| declare const EasyPostClient: typeof import('./EasyPost').default; | ||
| export = EasyPostClient; | ||
| export default EasyPostClient; |
Member
Author
There was a problem hiding this comment.
Reviewer Note
Typescript didn't like the mix of CJS and ESM syntax here. AI suggests changing it to this will keep it compatible with both but want to make sure.
Contributor
There was a problem hiding this comment.
Yea I would expect it to be export default here
ralexmatthews
approved these changes
Feb 19, 2026
Contributor
ralexmatthews
left a comment
ralexmatthews
left a comment
There was a problem hiding this comment.
Yea looks good to me from what I can tell 👍
|
|
||
| declare const EasyPostClient: typeof import('./EasyPost').default; | ||
| export = EasyPostClient; | ||
| export default EasyPostClient; |
Contributor
There was a problem hiding this comment.
Yea I would expect it to be export default here
sroomberg-ep
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
just typescript) to ensure syntax errors can't pass into prod (doing so exposed a couple small issues that needed to be fixed in the definitions)replTesting
just typescriptnow runs on CI to catch future errors, fixed the ones it caught here.Pull Request Type
Please select the option(s) that are relevant to this PR.