Improve the /cwiki command#775
Merged
Earthcomputer merged 6 commits intoEarthcomputer:fabricfrom Feb 19, 2026
Merged
Conversation
Earthcomputer
requested changes
Feb 9, 2026
| return null; | ||
| } | ||
|
|
||
| String pageName = URLEncoder.encode(title, StandardCharsets.UTF_8).replace('+', '_'); |
Owner
There was a problem hiding this comment.
I'm not sure I understand this line. Is it meant to be replacing spaces with underscores? Spaces get replaced with %20 after URL encoding, not +. Alternatively you could replace them before URL encoding, as I'm not sure that _ gets changed with URL encoding (not 100% sure on this)?
Contributor
Author
There was a problem hiding this comment.
Well, it might be outdated but this documentation says otherwise: https://docs.oracle.com/javase/8/docs/api/java/net/URLEncoder.html
Collaborator
There was a problem hiding this comment.
Not outdated, it works the same on Java 21.
src/main/java/net/earthcomputer/clientcommands/features/WikiRetriever.java
Outdated
Show resolved
Hide resolved
Earthcomputer
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
[Open article]clickable message sent after the article content and searching, mainly for accepting typos when entering the page name.