-
Notifications
You must be signed in to change notification settings - Fork 0
Hytd nonlocal #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
merge hytd
merge hytd
|
The process here is too long for me to carefully check everything. I suggest replacing Hexx with the full Hamiltonian output velocity matrix and comparing it with the velocity matrix from pyatb for a benchmark. |
| std::complex<double> kphase = std::complex<double>(cosp, sinp); | ||
|
|
||
| tmp.find_R(r_index); | ||
| tmp.add_to_matrix(hk, ncol, kphase * ModuleBase::IMAG_UNIT * std::complex<double>(dR[ix]), hk_type); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is kphase * ModuleBase::IMAG_UNIT * std::complex<double>(dR[ix]) for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
source/module_ri/RI_2D_Comm.h
Outdated
| TK* hk); | ||
|
|
||
| template <typename Tdata> | ||
| extern void add_partial_Hexx(const K_Vectors& kv, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does partial means?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
source/module_io/td_current_io.cpp
Outdated
| = rR[i_alpha]->find_matrix(iat1, iat2, r_index.x, r_index.y, r_index.z); | ||
| if (HlocR == nullptr) | ||
| { | ||
| rR[i_alpha]->insert_pair(atom_ij); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may need to allocate memory for rR here. A output test would be helpful to check if rR is consistent with ABACUS output r matrix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It has been allocated here (
| rR[i_alpha] = new hamilt::HContainer<double>(pv); |
Reminder
Linked Issue
Fix #...
Unit Tests and/or Case Tests for my changes
What's changed?
Any changes of core modules? (ignore if not applicable)